Skip to content

Fixes on specialization for let statements#460

Merged
rodrigogribeiro merged 3 commits into
mainfrom
specialize-fix-for-abi-encode
Jun 13, 2026
Merged

Fixes on specialization for let statements#460
rodrigogribeiro merged 3 commits into
mainfrom
specialize-fix-for-abi-encode

Conversation

@rodrigogribeiro

Copy link
Copy Markdown
Collaborator
  • Fixes an issue on specialization for let statements.

@rodrigogribeiro rodrigogribeiro requested a review from mbenke June 11, 2026 19:34

@mbenke mbenke left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple minor nits; needs merge conflict resolution.

Comment thread src/Solcore/Backend/Specialise.hs Outdated
Comment on lines +160 to +169
unless (null vars) $
nopanics
[ "Error: function ",
pretty name,
" cannot be specialised because it has an ambiguous type:\n ",
pretty scheme,
"\n variables: ",
prettys vars,
"\n do not occur in the argument/result types."
]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This duplicates the code aboce, might be worth extracting

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment thread std/Generic.solc Outdated
export {
Sum(*),
Generic,
maxWord

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why export maxWord ?

@rodrigogribeiro rodrigogribeiro force-pushed the specialize-fix-for-abi-encode branch from f111c8d to 77df280 Compare June 13, 2026 12:34
@rodrigogribeiro rodrigogribeiro force-pushed the specialize-fix-for-abi-encode branch from 87af727 to 8122451 Compare June 13, 2026 13:17
@rodrigogribeiro rodrigogribeiro merged commit 4018333 into main Jun 13, 2026
4 checks passed
@rodrigogribeiro rodrigogribeiro deleted the specialize-fix-for-abi-encode branch June 13, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants