Skip to content

Conversation

@fagsctvg
Copy link

No description provided.

@github-actions
Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@cameel
Copy link
Collaborator

cameel commented Dec 8, 2025

Here's the comment I made the last time @matheusaaguiar asked me about this PR. I guess I should have just posted it here. Anyway:

Is this change even correct? We use that value e.g. to find the deps/ directory and that's at the top-level. If I understand correctly, CMAKE_CURRENT_SOURCE_DIR is the dir containing the current CMakeFiles.txt so it will be the wrong one unless we're at the top level. I think it passes CI only because we currently don't invoke any of these changed .cmake files from other CMakeFiles.txt. If we did, this change would probably break things. Though I'd have to test this locally to make sure. I'm basing this only on a quick search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants