SSA CFG: add shared function registry across nested builders#16686
Merged
Conversation
clonker
force-pushed
the
ssa-cfg-builder-share-function-registry
branch
from
8d6a53c to
ee6668e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
m_functionDefinitionsin theSSACFGBuilderare currently copy-assigned into all child builders (for nested function definitions). This is not only computationally inefficient but also requires a lot more memory than would be necessary. This PR replaces it with aFunctionRegistrythat is shared across all builders.