SSA-CFG: Fix stack adjustments for codegen on conditional jump#16688
Merged
Conversation
clonker
approved these changes
May 7, 2026
When running codegen on a block which ends in a conditional jump, we save the stack before we continue with zero branch and then we restore it when come back and continue with non-zero branch. Notifying the assebly about the restored stack size is part of resetting the state and needs to happen before we attempt any stack shuffling. `prepareBlockExitStack` might shuffle the stack and so assembly notification must happen before that.
blishko
force-pushed
the
ssa-fix-stack-adjustments
branch
from
a74e6a0 to
7da228d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running codegen on a block which ends in a conditional jump, we save the stack before we continue with zero branch and then we restore it when come back and continue with non-zero branch. Notifying the assebly about the restored stack size is part of resetting the state and needs to happen before we attempt any stack shuffling.
prepareBlockExitStackmight shuffle the stack and so assembly notification must happen before that.