SSA CFG: Add printer#16709
Conversation
rodiazet
left a comment
rodiazet
left a comment
There was a problem hiding this comment.
I like it. Some comments regarding the syntax. Haven’e checked the code itself. I would like to agree on syntax first.
| // upsilon v0 -> ^v4 | ||
| // jump #1 | ||
| // #1: | ||
| // preds = #0, #3 |
There was a problem hiding this comment.
I would move to the line above together with the label:
#1: #0, #3 or #1: preds: #0, #3
| // jump #2 | ||
| // #2: | ||
| // preds = #0, #1 | ||
| // v6 = phi |
There was a problem hiding this comment.
In dot graph we have here a notation which shows what are possible block the value comes from. So maybe similar to upsilon we can have phi #0: v1, #1: v5.
There was a problem hiding this comment.
Hmmm. the whole point of the Pizlo form is that we don't have to have that :) I think as visualization it's fine, as textual IR I don't think we should add this.
There was a problem hiding this comment.
I agree, but on the other hand we already added a notation which allows us to easily see what are the connection in graph. It's pure visualization think but I'm not gonna die for this :)
|
Did you try to translate existing SSASFG tests expectations to this format? |
rodiazet
left a comment
rodiazet
left a comment
There was a problem hiding this comment.
Nice. LGTM. I think it would be good to at least make a test and try to translate existing SSACFG tests expectations to this format
2 participants
Adds a textual representation of the SSACFGs