Skip to content

ethdebug: Improve current testing infra#16727

Draft
djolertrk wants to merge 8 commits into
argotorg:developfrom
walnuthq:feature/ethdebug
Draft

ethdebug: Improve current testing infra#16727
djolertrk wants to merge 8 commits into
argotorg:developfrom
walnuthq:feature/ethdebug

Conversation

@djolertrk
Copy link
Copy Markdown

Handle multiple things ethdebug related:

  • Add LLVM lit tests (this could be interesting for codegen tests as well)
    $ lit -sv test/lit --param solc=build/solc/solc
  • Emit schema-compliant compilation resources so we can execute first "round-trip-tests" in producer (here) and in consumer soldb via conformance tests added into the format repo
  • Validate ETHDebug output against pinned schemas

@djolertrk djolertrk marked this pull request as draft May 15, 2026 14:53
@nikola-matic nikola-matic self-assigned this May 18, 2026
Copy link
Copy Markdown
Contributor

@nikola-matic nikola-matic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed earlier, can you please migrate the llvm-lit test to the new ethdebug isoltest (#16675 - merged this morning)?

I'll be doing some follow up tasks regarding the ethdebug isoltest, so feel free to let me know if you have any requests :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to get rid of all of these (brink, ens and prb-math), i.e. just drop the commits after a rebase - I fixed these some time ago.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I will do it.

@djolertrk
Copy link
Copy Markdown
Author

As discussed earlier, can you please migrate the llvm-lit test to the new ethdebug isoltest (#16675 - merged this morning)?

I'll be doing some follow up tasks regarding the ethdebug isoltest, so feel free to let me know if you have any requests :)

Hi @nikola-matic, thanks for the feedback! Yes sure! I will do it, and also include into CI the ethdebug compilation overhead (almost ready), and of course, if something is missing in the ethdebug isoltest, I will let you know.

And just to confirm, we do not want to include llvm lit at all in this PR, right?

@nikola-matic
Copy link
Copy Markdown
Contributor

And just to confirm, we do not want to include llvm lit at all in this PR, right?

Correct - team is very much used to the isoltest way of doing things, and reviewing will go much smoother with isoltest instead of llvm-lit for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants