ethdebug: Improve current testing infra#16727
Conversation
c49f8f2 to
4c86c71
Compare
Run: $ lit -sv test/lit --param solc=build/solc/solc
4c86c71 to
5186b7e
Compare
nikola-matic
left a comment
There was a problem hiding this comment.
As discussed earlier, can you please migrate the llvm-lit test to the new ethdebug isoltest (#16675 - merged this morning)?
I'll be doing some follow up tasks regarding the ethdebug isoltest, so feel free to let me know if you have any requests :)
There was a problem hiding this comment.
You should be able to get rid of all of these (brink, ens and prb-math), i.e. just drop the commits after a rebase - I fixed these some time ago.
Hi @nikola-matic, thanks for the feedback! Yes sure! I will do it, and also include into CI the ethdebug compilation overhead (almost ready), and of course, if something is missing in the And just to confirm, we do not want to include |
Correct - team is very much used to the isoltest way of doing things, and reviewing will go much smoother with isoltest instead of llvm-lit for the time being. |
Handle multiple things
ethdebugrelated:codegentests as well)soldbviaconformancetests added into theformatrepo