Skip to content

Remove EOF: libsolidity#16769

Merged
nikola-matic merged 1 commit into
developfrom
remove-eof-libsolidity
May 29, 2026
Merged

Remove EOF: libsolidity#16769
nikola-matic merged 1 commit into
developfrom
remove-eof-libsolidity

Conversation

@rodiazet
Copy link
Copy Markdown
Contributor

@rodiazet rodiazet commented May 22, 2026

This PR removes EOF support from libsolidity and pass std::nullopt flag downstream to libyul.
Removes libsolidity EOF-specific tests and limits testing to legacy only pipeline.

  • No AI tools were used
  • AI tools were used (details below)

Depends on: #16760

@rodiazet rodiazet mentioned this pull request May 22, 2026
2 tasks
@rodiazet rodiazet added EOF has dependencies The PR depends on other PRs that must be merged first labels May 25, 2026
Comment thread libsolidity/codegen/ir/IRGenerationContext.h Outdated
@rodiazet rodiazet force-pushed the remove-eof-libsolidity branch from 088861a to ed5a8ab Compare May 27, 2026 12:00
@rodiazet rodiazet force-pushed the remove-eof-solc branch 6 times, most recently from c57ba11 to 10ed593 Compare May 28, 2026 13:44
@rodiazet rodiazet force-pushed the remove-eof-libsolidity branch 3 times, most recently from ed3528f to 72594e0 Compare May 28, 2026 14:42
Base automatically changed from remove-eof-solc to develop May 28, 2026 14:42
@rodiazet rodiazet force-pushed the remove-eof-libsolidity branch from 72594e0 to a67f1be Compare May 28, 2026 14:43
@rodiazet rodiazet removed the has dependencies The PR depends on other PRs that must be merged first label May 28, 2026
@rodiazet rodiazet requested a review from matheusaaguiar May 28, 2026 14:46
@rodiazet rodiazet force-pushed the remove-eof-libsolidity branch from a67f1be to 40c0d22 Compare May 28, 2026 15:00
@rodiazet rodiazet force-pushed the remove-eof-libsolidity branch from 40c0d22 to c06a4e2 Compare May 28, 2026 15:20
@rodiazet rodiazet requested review from cameel and nikola-matic May 28, 2026 20:48
Comment thread libevmasm/Assembly.cpp
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was touching libevmasm here necessary?

Copy link
Copy Markdown
Contributor Author

@rodiazet rodiazet May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because this PR removes test which covers 2703 error.

@nikola-matic nikola-matic merged commit fb19f71 into develop May 29, 2026
83 checks passed
@nikola-matic nikola-matic deleted the remove-eof-libsolidity branch May 29, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants