SSA CFG spill: fix miscounting in spill set#16829
Merged
Merged
Conversation
…d slots for a user-defined call that can continue
clonker
force-pushed
the
ssa-cfg-fix-spill-miscount-bug
branch
from
5fe0ff3 to
f007b69
Compare
blishko
approved these changes
Jun 24, 2026
blishko
left a comment
blishko
left a comment
Contributor
There was a problem hiding this comment.
This special-casing feels a bit weird. We should revisit the design for handling function calls at some point.
Member
Author
Fully agree, it did feel weird to me, too. Ideally there is a unified interface that does this stuff for us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spill set would miscount the number of consumed slots for a user-defined call that can continue. The produced symbolic stack is only ever used to determine if something needs to be spilled additionally. Simulating to consume too few slots can only ever lead to a situation where we spill too much.