Intern addresses as &[G; 32] to cut kernel FFT cost#417
Merged
Conversation
arthurpaulino
force-pushed
the
ap/kernel-opts
branch
from
b9e71b6 to
157da06
Compare
| -- io_get_info is unconstrained; the prover provides (0, 0) for blob addresses. | ||
| -- Soundness: if the prover lies and skips a real constant, type checking will fail. | ||
| let (_, len) = io_get_info(addr); | ||
| let (_, len) = io_get_info(load(addr)); |
Member
There was a problem hiding this comment.
I believe this is doing a lookup and loading the addresses into columns JUST to get a hint. The hint should somehow come from the pointer alone. Is this possible? Perhaps that will need a new io_load_info operation or something?
Open
arthurpaulino
force-pushed
the
ap/kernel-opts
branch
from
157da06 to
b004695
Compare
Replace the by-value `[G; 32]` address type with `type Addr = &[G; 32]`. Aiur `store` content-dedups structurally equal arrays to one canonical pointer, so address equality reduces to pointer subtraction and every function carrying addresses drops 31 columns per address argument. `lake exe kernel String.Internal.append`: total FFT 2515875651 -> 2152947064 (-14.4%), total width 48210 -> 37903. ixvm test suite: 283 pass, 0 fail.
arthurpaulino
force-pushed
the
ap/kernel-opts
branch
from
b004695 to
f205dba
Compare
gabriel-barrett
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the by-value
[G; 32]address type withtype Addr = &[G; 32]. Aiurstorecontent-dedups structurally equal arrays to one canonical pointer, so address equality reduces to pointer subtraction and every function carrying addresses drops 31 columns per address argument.lake exe kernel String.Internal.append: total FFT 2515875651 ->2152947064 (-14.4%), total width 48210 -> 37903. ixvm test suite: 283 pass, 0 fail.