multi-plonk#54
Open
gabriel-barrett wants to merge 1 commit into
Open
Conversation
arthurpaulino
approved these changes
May 14, 2026
Member
arthurpaulino
left a comment
arthurpaulino
left a comment
There was a problem hiding this comment.
This is a nice spike exploration of the territory, but still needs a lot of work to get the code to a good state. There's a lot of types redefined from multi-stark, like the lookup types.
Also, it's missing the #52 trick @samuelburnham.
I'm approving to settle self-contained work. But this PR needs proper follow-ups before we use the multi-plonk code, especially if we're planning to use both multi-plonk and multi-stark as dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
multi-plonkcrate, which reimplements themulti-starkusing the KZG PCS through Arkworks'poly-commit. Eventually we should think about merging these two crates, but that will require a lot of trait integration.