Improve workflow to include all user languages in descending order#2
Improve workflow to include all user languages in descending order#2arhamkhnz merged 3 commits intoarhamkhnz:mainfrom sathwikhbhat:enhancement/dynamic-languages-workflow
Conversation
|
I’d say keep this configurable. In some cases users won’t want all languages printed. If languages are configured, use only those, otherwise print all. |
|
I rightfully agree with you. However, not all users have JavaScript, Vue.js, PHP, C#, or JSX set as their default languages. So, when someone tries to use this workflow, they may get zeros for the languages listed above and then see 13,000 lines categorised under "Other Languages," which is not the preferred outcome. It would be better to keep all languages and then, perhaps, include a section in the README explaining how to configure custom languages and how to ignore others. |
|
Also, I just happened to notice that |
|
Instead of just pointing people to the README to change code, you can add INCLUDE_LANGS and EXCLUDE_LANGS vars (comma-separated). By default it’ll take all, but if someone wants to filter, they just set these. That way it covers multiple use cases without touching the workflow code. Also, fixes like .xml or other extensions can be handled here itself. |
…iltering without workflow changes
|
@arhamkhnz I believe I have completed everything as you mentioned earlier. Please acknowledge my PR. Thank you. |
|
I’ll review it soon. |
Description
Why is this change needed?
Changes Made
Closes #1