Feature/static from address #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
| // forward and the value is an array of email addresses to which to send the | ||
| // message. | ||
| var defaultConfig = { | ||
| fromEmail: "noreply@example.com" |
Owner
There was a problem hiding this comment.
This line needs a comma at the end. It's causing an error in the tests.
Owner
|
@yanokwa Thanks for this contribution. I commented on a syntax error that is causing an error in the tests. Could you resolve that in your branch? |
Cleaner explanation
Example should match
Contributor
Author
|
Well, the good news is that I've fixed the linting errors. The bad news is that not sure how the testing framework works (I'm new to npm) so not confident trying to write the tests. |
Owner
|
Thanks! This is merged and released as v2.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure you want this feature, but figured I'd contribute it anyway. I prefer having a static return address.