Merged
Conversation
KOBAYASHI Kazuhiro (kobkaz)
requested a review
from sksat (sksat)
as a code owner
KOBAYASHI Kazuhiro (kobkaz)
force-pushed
the
minor_refactors
branch
from
2727396 to
44c29f4
Compare
Member
|
すくなくともアイデアはとてもよさそうです。コードの中身はまだ見られてないです。 |
Member
|
KOBAYASHI Kazuhiro (@kobkaz) Cargo.toml が conflict しちゃってるのでそこだけ解決お願いします。マージはこっちでやります。 |
KOBAYASHI Kazuhiro (kobkaz)
force-pushed
the
minor_refactors
branch
from
44c29f4 to
e2a0ac6
Compare
Member
Author
|
conflict解消しました |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
今後の変更の準備として、いくつかの簡単なリファクタリングとtracing-subscriberの設定をする
spaghetti::Config::runをapp::runに移動run関数内の "No such plug" エラーはunreachable!になる