Skip to content

feat: add no_whitespace parameter#17

Merged
ilyichv merged 4 commits intomainfrom
feat/no-whitespace
Jul 5, 2023
Merged

feat: add no_whitespace parameter#17
ilyichv merged 4 commits intomainfrom
feat/no-whitespace

Conversation

@ilyichv
Copy link
Copy Markdown
Member

@ilyichv ilyichv commented May 25, 2023

Description

Add a new parameter no_whitespace for trimming an removing whitespaces automatically from parameters.
By default, it's now applied to id and arke_id

Related Issue

Resolve #4

@arkemishub/backend-experts
Let me know if you prefer to add it somewhere else, I set it to false for most of default Units

@ilyichv ilyichv requested a review from a team as a code owner May 25, 2023 07:13
@ilyichv
Copy link
Copy Markdown
Member Author

ilyichv commented May 26, 2023

@ErikFerrari proposed to rename no_whitespace into strip. I actually like it, what do you think @dorianmercatante?

Copy link
Copy Markdown
Member

@ErikFerrari ErikFerrari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed all the no_whitespace to strip

Comment thread lib/arke.ex Outdated
Comment thread lib/arke.ex Outdated
Comment thread lib/arke.ex Outdated
Comment thread lib/arke.ex Outdated
Comment thread lib/arke.ex Outdated
Comment thread lib/arke.ex Outdated
Comment thread lib/arke/core/parameter.ex Outdated
Comment thread lib/arke/struct_manager.ex Outdated
Comment thread lib/arke/system.ex Outdated
Comment thread lib/arke/validator.ex Outdated
Comment thread lib/arke.ex Outdated
@ilyichv ilyichv merged commit b9b35bc into main Jul 5, 2023
@ilyichv ilyichv deleted the feat/no-whitespace branch July 5, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] - parameter to handle trail and starting whitespaces

2 participants