Use lastest version of jsdom to fix build issues with newer versions of Node#47
Merged
voter101 merged 1 commit intoarkency:masterfrom Nov 6, 2015
Merged
Use lastest version of jsdom to fix build issues with newer versions of Node#47voter101 merged 1 commit intoarkency:masterfrom
voter101 merged 1 commit intoarkency:masterfrom
Conversation
|
Please merge if working 👍 |
voter101
added a commit
that referenced
this pull request
Nov 6, 2015
Use lastest version of jsdom to fix build issues with newer versions of Node
Contributor
|
Tests doesn't work. Sorry I merged it so fast without actually checking. Ref. #50 |
Contributor
|
Fixed in d7b7a45 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having similar issues as the ones detailed here #45. The issue is directly related to the contextify package that jsdom was using. The latest version no longer uses that package (jsdom/jsdom#1188)