chore: remove em dashes throughout repo#109
Open
soleil-colza wants to merge 6 commits intomainfrom
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Em dashes (
U+2014) are banned from any text that ships in the repo (committed source, runtime strings, docs, READMEs, code comments). This PR catches up the existing content. 238 occurrences across 72 files swapped for grammatically appropriate punctuation.Replacement strategy
— connector(where the connector isso/but/and/or): replaced with, connector(comma).X — Y(introducing an explanation, list, or quote): replaced withX: Y(colon).Anonymous id: <id> — Arkor Cloud uses this id...) were rephrased with a period or wrapped in parentheses.loss=${loss ?? \"—\"}swapped for a single hyphen.Coordination with PR #108
Both this PR and #108 touch
packages/cli-internal/src/templates.tsandpackages/create-arkor/README.md. #108 removes a couple of paragraphs (the npm-vs-binary parenthetical and thenpx arkor loginexample); this PR rewrites em dashes in the same files. Whichever lands second resolves the conflict trivially (take #108's deletions, then re-apply em-dash fixes to the surviving lines).Test plan
pnpm typecheckpassespackages/cli-internal/src/git.test.tsthat already fails onmain(unrelated to em dashes; depends on local GPG / git config)SKIP_E2E_INSTALL=1 pnpm --filter @arkor/e2e-cli testpasses (38 tests)mint broken-linkscleangrep -rc \"—\" --include=\"*.{md,mdx,ts,tsx,mjs,js}\"returns zero in non-build files