Skip to content

ci(release): retry npm view in verify step to tolerate registry lag#41

Merged
soleil-colza merged 1 commit intomainfrom
eng-497
Apr 28, 2026
Merged

ci(release): retry npm view in verify step to tolerate registry lag#41
soleil-colza merged 1 commit intomainfrom
eng-497

Conversation

@k-taro56
Copy link
Copy Markdown
Contributor

Summary

  • The Verify published packages step in release.yaml ran npm view immediately after pnpm publish and treated a single 404 as a fatal error.
  • During the v0.0.1-alpha.1 release the publish itself succeeded for both packages, but the verify step ran <1s after publish and got a 404 for create-arkor because the registry index hadn't replicated yet, failing the workflow and skipping the draft GitHub Release step.
  • Wrap the npm view call in a poll loop (5s interval, up to 120 attempts → ~10 min budget) so transient registry replication lag — including longer lags during npm incidents — no longer fails the release.

The retry only treats an exact version match as success, so a stale "previous version" response still counts as not-yet-visible and keeps polling.

Test plan

  • Workflow YAML lints cleanly (no syntax errors)
  • Next release tag triggers the workflow and the verify step succeeds on the first attempt for the normal case
  • If verification never succeeds within ~10 min, the step exits 1 with the last response logged

@k-taro56 k-taro56 self-assigned this Apr 28, 2026
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k-taro56 has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@k-taro56 k-taro56 requested a review from soleil-colza April 28, 2026 13:17
@soleil-colza soleil-colza merged commit 6b820f2 into main Apr 28, 2026
8 of 9 checks passed
@soleil-colza soleil-colza deleted the eng-497 branch April 28, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants