feat: Support Homebrew managed installations of Topo#266
Merged
Conversation
awphi
reviewed
May 18, 2026
awphi
left a comment
awphi
left a comment
Contributor
There was a problem hiding this comment.
One other missing piece is that the version check that exists on topo health (dependencies.go) will currently suggest users run topo upgrade when out of date which is now not always accurate.
muchzill4
force-pushed
the
homebrew-upgrade-guidance
branch
from
ec8f05b to
c1afbc6
Compare
muchzill4
commented
May 18, 2026
| return 0 ;; | ||
| esac | ||
|
|
||
| case "$(uname -s)" in |
Contributor
Author
There was a problem hiding this comment.
Note to self: this is a bit weird. Should we not allow installing to /usr/local/bin if user desires to do so?
Contributor
There was a problem hiding this comment.
Yeah, it feels like we shouldn't do this?
th3james
approved these changes
May 19, 2026
| return 0 ;; | ||
| esac | ||
|
|
||
| case "$(uname -s)" in |
Contributor
There was a problem hiding this comment.
Yeah, it feels like we shouldn't do this?
awphi
approved these changes
May 20, 2026
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
muchzill4
force-pushed
the
homebrew-upgrade-guidance
branch
from
ad4dfc7 to
8835e26
Compare
awphi
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
topo upgradechangesupgradesub-command when we detecttopois managed by brewupgradeis invoked, refuse to upgrade homebrew if it's managed by brewscripts/install.shchanges--pathlooks homebrew-like