-
-
Notifications
You must be signed in to change notification settings - Fork 13
Add cache mirror support to redirector update workflow #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe workflows were simplified: detailed cache mirroring, artifact download/compare, per-node mirror logic, SSH install/reload, and many cache-specific status checks were removed or replaced with no-op/touch/status=true steps in infrastructure-update-redirector-config.yml. Multiple lftp timeouts were reduced (5m → 3m). Separately, generate-web-directory.yml gained steps to install an SSH key/known_hosts and perform an SSH reload of the redirector. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
602e8d3 to
f6a226f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/infrastructure-update-redirector-config.yml:
- Around line 454-478: The script uses the uninitialized variable exit_status in
the conditionals (the checks [[ "${exit_status}" -eq 0 ]] and [[
"${exit_status}" -eq 124 ]]) which will error if the curl block is skipped; fix
this by initializing exit_status=0 (or another safe default) before the curl/if
block and ensure any branch that can set it (the lftp mirror command) assigns to
exit_status (e.g., capture its exit code into exit_status) so the subsequent
checks in this step (and the same pattern in the other jobs like Debs-beta,
Debs-stable, Images-stable, Images-archive) always operate on a defined integer
value.
1cadd98 to
74e12ba
Compare
Extend the redirector configuration workflow to support cache mirrors: - Add cache to build platform matrix - Add Cache-index job to fetch mirrors from NetBox - Add Cache check job to compare mirrors against source - Add cache redirector config generation (port 8084) - Handle cache artifacts mirroring from /cache/artifacts Signed-off-by: Igor Pecovnik <igor@armbian.com>
74e12ba to
fbc54a3
Compare
Extend the redirector configuration workflow to support cache mirrors: