Skip to content

Conversation

@igorpecovnik
Copy link
Member

Extend the redirector configuration workflow to support cache mirrors:

  • Add cache to build platform matrix
  • Add Cache-index job to fetch mirrors from NetBox
  • Add Cache check job to compare mirrors against source
  • Add cache redirector config generation (port 8084)
  • Handle cache artifacts mirroring from /cache/artifacts

@github-actions github-actions bot added 02 Milestone: First quarter release size/medium PR with more then 50 and less then 250 lines GitHub Actions GitHub Actions code Needs review Seeking for review labels Jan 23, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

The workflows were simplified: detailed cache mirroring, artifact download/compare, per-node mirror logic, SSH install/reload, and many cache-specific status checks were removed or replaced with no-op/touch/status=true steps in infrastructure-update-redirector-config.yml. Multiple lftp timeouts were reduced (5m → 3m). Separately, generate-web-directory.yml gained steps to install an SSH key/known_hosts and perform an SSH reload of the redirector.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • armbianworker
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and concisely describes the main change: adding cache mirror support to the redirector update workflow, which aligns perfectly with the changeset.
Description check ✅ Passed The description is well-related to the changeset, providing specific details about cache support including build matrix changes, new jobs, config generation, and artifact handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fixing-redi

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/infrastructure-update-redirector-config.yml:
- Around line 454-478: The script uses the uninitialized variable exit_status in
the conditionals (the checks [[ "${exit_status}" -eq 0 ]] and [[
"${exit_status}" -eq 124 ]]) which will error if the curl block is skipped; fix
this by initializing exit_status=0 (or another safe default) before the curl/if
block and ensure any branch that can set it (the lftp mirror command) assigns to
exit_status (e.g., capture its exit code into exit_status) so the subsequent
checks in this step (and the same pattern in the other jobs like Debs-beta,
Debs-stable, Images-stable, Images-archive) always operate on a defined integer
value.

@igorpecovnik igorpecovnik force-pushed the fixing-redi branch 5 times, most recently from 1cadd98 to 74e12ba Compare January 23, 2026 08:43
Extend the redirector configuration workflow to support cache mirrors:
- Add cache to build platform matrix
- Add Cache-index job to fetch mirrors from NetBox
- Add Cache check job to compare mirrors against source
- Add cache redirector config generation (port 8084)
- Handle cache artifacts mirroring from /cache/artifacts

Signed-off-by: Igor Pecovnik <igor@armbian.com>
@igorpecovnik igorpecovnik merged commit acb5625 into main Jan 23, 2026
6 of 7 checks passed
@igorpecovnik igorpecovnik deleted the fixing-redi branch January 23, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release GitHub Actions GitHub Actions code Needs review Seeking for review size/medium PR with more then 50 and less then 250 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants