Skip to content

Conversation

@igorpecovnik
Copy link
Member

Summary

  • Add `DESKTOP_APPGROUPS_SELECTED: "browsers,programming"` to the stable Ubuntu XFCE desktop target for fast HDMI boards
  • Aligns stable XFCE configuration with nightly and community XFCE targets which already include this setting

Test plan

  • Script generates valid YAML
  • Configuration matches nightly/community XFCE targets

@github-actions github-actions bot added 02 Milestone: First quarter release size/small PR with less then 50 lines labels Jan 27, 2026
Add browsers and programming app groups to the Ubuntu stable XFCE desktop build for fast HDMI boards, matching the configuration used in nightly and community XFCE targets.

Signed-off-by: Igor Pecovnik <igor@armbian.com>
@github-actions github-actions bot added the Needs review Seeking for review label Jan 27, 2026
@igorpecovnik igorpecovnik force-pushed the add-desktop-appgroups-to-stable-xfce branch from deec3bf to 9205b42 Compare January 27, 2026 06:48
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

The change adds a single configuration parameter to a YAML generation script. Specifically, DESKTOP_APPGROUPS_SELECTED: "browsers,programming" is inserted into the DESKTOP_ENVIRONMENT block within the stable desktop YAML generation path in scripts/generate_targets.py. This modifies the configuration without altering control flow or other logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-desktop-appgroups-to-stable-xfce

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@igorpecovnik igorpecovnik merged commit dfdf412 into main Jan 27, 2026
6 of 7 checks passed
@igorpecovnik igorpecovnik deleted the add-desktop-appgroups-to-stable-xfce branch January 27, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Needs review Seeking for review size/small PR with less then 50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants