-
-
Notifications
You must be signed in to change notification settings - Fork 14
targets: change community builds from forky to trixie #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update the community minimal CLI target to use Debian Trixie instead of Debian Forky. Also removes Forky fallback patterns from exposed.map generation since Trixie is now the primary testing release. - community-forky-all → community-trixie-all - RELEASE: forky → RELEASE: trixie - Remove forky fallback patterns (trixie is primary) Signed-off-by: Igor Pecovnik <igor@armbian.com>
WalkthroughThe script Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@scripts/generate_targets.py`:
- Around line 1059-1072: Update the documentation references from the old target
name to the new one: replace occurrences of community-forky-all with
community-trixie-all in release-targets/README.md (specifically in the
"Community-maintained builds" section) and ensure any explanatory text or
examples that mention the target name are updated to reflect the new vars
(RELEASE: trixie, BUILD_MINIMAL, BUILD_DESKTOP) used by the community-trixie-all
entry in scripts/generate_targets.py.
| # Debian trixie minimal CLI for all community boards | ||
| community-trixie-all: | ||
| enabled: yes | ||
| configs: [ armbian-community ] | ||
| pipeline: | ||
| gha: *armbian-gha | ||
| build-image: "yes" | ||
| vars: | ||
| RELEASE: forky | ||
| RELEASE: trixie | ||
| BUILD_MINIMAL: "yes" | ||
| BUILD_DESKTOP: "no" | ||
| items: | ||
| """ | ||
| # Combine all lists for Debian Forky | ||
| # Combine all lists for Debian Trixie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for references to the old target name "community-forky-all"
echo "=== Searching for 'community-forky-all' in entire repository ==="
rg 'community-forky-all' -i
echo ""
echo "=== Searching for 'community-forky' specifically ==="
rg 'community-forky' -i
echo ""
echo "=== Checking .github directory for workflow references ==="
fd . '.github' -type f | head -20Repository: armbian/armbian.github.io
Length of output: 617
🏁 Script executed:
#!/bin/bash
cat -n release-targets/README.md | head -50
echo ""
echo "=== Searching for context around community builds ==="
rg -A 2 -B 2 'community-' release-targets/README.mdRepository: armbian/armbian.github.io
Length of output: 2924
Documentation update required before merge.
The code changes are internally consistent, but release-targets/README.md still references the old target name community-forky-all. Update the documentation to reflect the new target name community-trixie-all:
Required documentation update
In release-targets/README.md, update the Community-maintained builds section:
- `community-forky-all`: Debian Forky minimal CLI for all boards
+ `community-trixie-all`: Debian Trixie minimal CLI for all boards🤖 Prompt for AI Agents
In `@scripts/generate_targets.py` around lines 1059 - 1072, Update the
documentation references from the old target name to the new one: replace
occurrences of community-forky-all with community-trixie-all in
release-targets/README.md (specifically in the "Community-maintained builds"
section) and ensure any explanatory text or examples that mention the target
name are updated to reflect the new vars (RELEASE: trixie, BUILD_MINIMAL,
BUILD_DESKTOP) used by the community-trixie-all entry in
scripts/generate_targets.py.
Summary
community-forky-all→community-trixie-allTrixie is now the primary testing release, replacing Forky as the fallback.
Test plan