Exclude end-of-support boards from armbian-images.json

[igorpecovnik]

Summary

• Load .eos board configs so their support level is known
• Skip EOS boards during JSON generation so they no longer appear in the download index

Test plan

• Verify boards with .eos config extension are excluded from generated armbian-images.json
• Verify boards with other extensions (.conf, .csc, .wip, .tvb) are still included

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d02cbde9-c973-4de7-b504-3a5c9c4ca57f

📥 Commits

Reviewing files that changed from the base of the PR and between 2878878 and e367107.

📒 Files selected for processing (1)

• scripts/generate-armbian-images-json.sh

🚧 Files skipped from review as they are similar to previous changes (1)

• scripts/generate-armbian-images-json.sh

---

Walkthrough

The script scripts/generate-armbian-images-json.sh was modified to include *.eos when discovering board definition files in addition to *.conf, *.csc, *.wip, and *.tvb. During JSON emission, the script now skips boards whose normalized BOARD_SLUG maps to "eos" in BOARD_SUPPORT_MAP[...]. It also skips emitting rows for reusable boards when reusable_support (lowercased) equals "eos".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: excluding end-of-support boards from the JSON output file.
Description check	✅ Passed	The description clearly outlines the changes (loading .eos configs, skipping EOS boards during generation) and includes a concrete test plan.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jsonfff

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@scripts/generate-armbian-images-json.sh`:
- Around line 583-585: The EOS filter currently only skips the base board using
BOARD_SUPPORT_MAP[$BOARD_SLUG], but the reusable-board emission loop still emits
rows for reusable boards whose support is "eos"; update the reusable emission
logic to perform the same check and skip those entries. Specifically, inside the
reusable-board loop (the block that emits the reusable rows), check
BOARD_SUPPORT_MAP for the reusable board's slug variable (the same map used for
the base board, e.g. BOARD_SUPPORT_MAP[$REUSABLE_SLUG] or whatever slug variable
is used in that loop) and continue when it equals "eos" before emitting; ensure
the check mirrors the base-board guard so EOS boards are never written to
armbian-images.json.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ebc6c33d-8148-4c47-ad20-5bb9020d4e67

📥 Commits

Reviewing files that changed from the base of the PR and between e5e7ebc and 2878878.

📒 Files selected for processing (1)

• scripts/generate-armbian-images-json.sh