Skip to content

release-targets: add radxa-dragon-q6a and radxa-nio-12l with ufs extension#292

Merged
igorpecovnik merged 1 commit intomainfrom
release-targets-add-qcs6490-genio
Apr 24, 2026
Merged

release-targets: add radxa-dragon-q6a and radxa-nio-12l with ufs extension#292
igorpecovnik merged 1 commit intomainfrom
release-targets-add-qcs6490-genio

Conversation

@igorpecovnik
Copy link
Copy Markdown
Member

Summary

Add two new Qualcomm / MediaTek ARM64 boards with UFS storage to targets-release-standard-support.manual:

Board BOARDFAMILY BRANCH
radxa-dragon-q6a qcs6490 current
radxa-nio-12l genio edge

Both boards ship with UFS as their primary storage, so enable extensions/ufs.sh — creates a UFS-aligned image (requires sfdisk >= 2.41 from util-linux on the build host).

Added to all four existing standard-support blocks:

  • minimal-stable-debian-uefi — Debian trixie minimal
  • minimal-stable-ubuntu-current-uefi — Ubuntu noble minimal
  • desktop-stable-ubuntu-gnome-uefi — Ubuntu noble GNOME
  • desktop-stable-ubuntu-cinnamon-uefi — Ubuntu noble Cinnamon

The "-uefi" suffix on these blocks is a category label, not a hard constraint — thinkpad-x13s (also a non-UEFI Qualcomm board) is already added to the two desktop blocks under the same convention.

Test plan

  • Next release run picks up both boards across all four blocks
  • ufs extension successfully produces UFS-aligned images for both
  • Produced images boot on the target hardware

@github-actions github-actions Bot added size/small PR with less then 50 lines 05 Milestone: Second quarter release Needs review Seeking for review labels Apr 24, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f318eba4-9701-4673-80b8-87ee68f1c81b

📥 Commits

Reviewing files that changed from the base of the PR and between 233dc17 and 0be7da0.

📒 Files selected for processing (1)
  • release-targets/targets-release-standard-support.manual
✅ Files skipped from review due to trivial changes (1)
  • release-targets/targets-release-standard-support.manual

Walkthrough

Adds four new build-matrix entries to release-targets/targets-release-standard-support.manual. Introduces two Radxa board entries: radxa-dragon-q6a on the current branch and radxa-nio-12l on the edge branch, both with ENABLE_EXTENSIONS set to "ufs". Entries are added across Debian minimal UEFI, Ubuntu minimal-current UEFI, Ubuntu GNOME UEFI, and Ubuntu Cinnamon UEFI target groups. All changes are additive; no existing items or logic were removed or modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding two boards (radxa-dragon-q6a and radxa-nio-12l) with UFS extension to release targets.
Description check ✅ Passed The description provides comprehensive context about the boards being added, their specifications, which target blocks they're added to, and includes a detailed test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release-targets-add-qcs6490-genio

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@igorpecovnik igorpecovnik requested review from HeyMeco April 24, 2026 08:11
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
release-targets/targets-release-standard-support.manual (1)

22-23: Operational consideration: UFS extension requires sfdisk >= 2.41.

The UFS extension requires sfdisk version 2.41 or higher on the build host (as noted in the PR objectives). Ensure that:

  1. Build hosts/CI runners have the required version of sfdisk
  2. Documentation is updated to reflect this dependency
  3. Build failures due to version mismatches are clearly diagnosed

Also applies to: 43-44, 64-65, 85-86

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@release-targets/targets-release-standard-support.manual` around lines 22 -
23, Entries that enable the UFS extension (ENABLE_EXTENSIONS: "ufs") require
sfdisk >= 2.41 on the build host; update the content near each
ENABLE_EXTENSIONS: "ufs" entry to document this requirement, ensure CI/build
images are provisioned with sfdisk >= 2.41, and add a pre-build check (a small
script invoked by the build/CI pipeline, e.g., ensure_sfdisk_version) that
parses `sfdisk --version`, verifies it is >= 2.41, and fails early with a clear
diagnostic message explaining the required version and remediation steps; apply
this change to all entries that set ENABLE_EXTENSIONS: "ufs".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@release-targets/targets-release-standard-support.manual`:
- Around line 22-23: Entries that enable the UFS extension (ENABLE_EXTENSIONS:
"ufs") require sfdisk >= 2.41 on the build host; update the content near each
ENABLE_EXTENSIONS: "ufs" entry to document this requirement, ensure CI/build
images are provisioned with sfdisk >= 2.41, and add a pre-build check (a small
script invoked by the build/CI pipeline, e.g., ensure_sfdisk_version) that
parses `sfdisk --version`, verifies it is >= 2.41, and fails early with a clear
diagnostic message explaining the required version and remediation steps; apply
this change to all entries that set ENABLE_EXTENSIONS: "ufs".

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dca14504-569c-474c-9ff4-dbd9b65db020

📥 Commits

Reviewing files that changed from the base of the PR and between 65b2234 and 233dc17.

📒 Files selected for processing (1)
  • release-targets/targets-release-standard-support.manual

@HeyMeco
Copy link
Copy Markdown
Contributor

HeyMeco commented Apr 24, 2026

Just to make sure these are additional and don’t replace the standard images right?

@igorpecovnik
Copy link
Copy Markdown
Member Author

Yes, additional.

@HeyMeco
Copy link
Copy Markdown
Contributor

HeyMeco commented Apr 24, 2026

What about DOCKER_ARMBIAN_BASE_IMAGE="debian:trixie" ?

@igorpecovnik
Copy link
Copy Markdown
Member Author

…nsion

Two new Qualcomm/MediaTek ARM64 boards with UFS storage:

  * radxa-dragon-q6a — BOARDFAMILY qcs6490, KERNEL_TARGET=current
  * radxa-nio-12l    — BOARDFAMILY genio,   KERNEL_TARGET=edge

Both ship with UFS as primary storage, so enable the `ufs` extension
(extensions/ufs.sh — creates a UFS-aligned image, requires
sfdisk >= 2.41 from util-linux).

Added to all four existing standard-support blocks to match the
thinkpad-x13s pattern (which is also a non-UEFI board added to the
"-uefi" blocks — the suffix is a category label, not a constraint):

  * minimal-stable-debian-uefi          (Debian trixie  minimal)
  * minimal-stable-ubuntu-current-uefi  (Ubuntu noble   minimal)
  * desktop-stable-ubuntu-gnome-uefi    (Ubuntu noble   gnome)
  * desktop-stable-ubuntu-cinnamon-uefi (Ubuntu noble   cinnamon)
@igorpecovnik igorpecovnik force-pushed the release-targets-add-qcs6490-genio branch from 233dc17 to 0be7da0 Compare April 24, 2026 10:27
@github-actions
Copy link
Copy Markdown

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Apr 24, 2026
@igorpecovnik igorpecovnik merged commit af85c4f into main Apr 24, 2026
8 checks passed
@igorpecovnik igorpecovnik deleted the release-targets-add-qcs6490-genio branch April 24, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants