release-targets: add radxa-dragon-q6a and radxa-nio-12l with ufs extension#292
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdds four new build-matrix entries to release-targets/targets-release-standard-support.manual. Introduces two Radxa board entries: Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
release-targets/targets-release-standard-support.manual (1)
22-23: Operational consideration: UFS extension requires sfdisk >= 2.41.The UFS extension requires
sfdiskversion 2.41 or higher on the build host (as noted in the PR objectives). Ensure that:
- Build hosts/CI runners have the required version of
sfdisk- Documentation is updated to reflect this dependency
- Build failures due to version mismatches are clearly diagnosed
Also applies to: 43-44, 64-65, 85-86
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@release-targets/targets-release-standard-support.manual` around lines 22 - 23, Entries that enable the UFS extension (ENABLE_EXTENSIONS: "ufs") require sfdisk >= 2.41 on the build host; update the content near each ENABLE_EXTENSIONS: "ufs" entry to document this requirement, ensure CI/build images are provisioned with sfdisk >= 2.41, and add a pre-build check (a small script invoked by the build/CI pipeline, e.g., ensure_sfdisk_version) that parses `sfdisk --version`, verifies it is >= 2.41, and fails early with a clear diagnostic message explaining the required version and remediation steps; apply this change to all entries that set ENABLE_EXTENSIONS: "ufs".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@release-targets/targets-release-standard-support.manual`:
- Around line 22-23: Entries that enable the UFS extension (ENABLE_EXTENSIONS:
"ufs") require sfdisk >= 2.41 on the build host; update the content near each
ENABLE_EXTENSIONS: "ufs" entry to document this requirement, ensure CI/build
images are provisioned with sfdisk >= 2.41, and add a pre-build check (a small
script invoked by the build/CI pipeline, e.g., ensure_sfdisk_version) that
parses `sfdisk --version`, verifies it is >= 2.41, and fails early with a clear
diagnostic message explaining the required version and remediation steps; apply
this change to all entries that set ENABLE_EXTENSIONS: "ufs".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: dca14504-569c-474c-9ff4-dbd9b65db020
📒 Files selected for processing (1)
release-targets/targets-release-standard-support.manual
|
Just to make sure these are additional and don’t replace the standard images right? |
|
Yes, additional. |
|
What about |
…nsion Two new Qualcomm/MediaTek ARM64 boards with UFS storage: * radxa-dragon-q6a — BOARDFAMILY qcs6490, KERNEL_TARGET=current * radxa-nio-12l — BOARDFAMILY genio, KERNEL_TARGET=edge Both ship with UFS as primary storage, so enable the `ufs` extension (extensions/ufs.sh — creates a UFS-aligned image, requires sfdisk >= 2.41 from util-linux). Added to all four existing standard-support blocks to match the thinkpad-x13s pattern (which is also a non-UEFI board added to the "-uefi" blocks — the suffix is a category label, not a constraint): * minimal-stable-debian-uefi (Debian trixie minimal) * minimal-stable-ubuntu-current-uefi (Ubuntu noble minimal) * desktop-stable-ubuntu-gnome-uefi (Ubuntu noble gnome) * desktop-stable-ubuntu-cinnamon-uefi (Ubuntu noble cinnamon)
233dc17 to
0be7da0
Compare
|
✅ This PR has been reviewed and approved — all set for merge! |
Summary
Add two new Qualcomm / MediaTek ARM64 boards with UFS storage to
targets-release-standard-support.manual:radxa-dragon-q6aqcs6490currentradxa-nio-12lgenioedgeBoth boards ship with UFS as their primary storage, so enable
extensions/ufs.sh— creates a UFS-aligned image (requiressfdisk >= 2.41from util-linux on the build host).Added to all four existing standard-support blocks:
minimal-stable-debian-uefi— Debian trixie minimalminimal-stable-ubuntu-current-uefi— Ubuntu noble minimaldesktop-stable-ubuntu-gnome-uefi— Ubuntu noble GNOMEdesktop-stable-ubuntu-cinnamon-uefi— Ubuntu noble CinnamonThe "-uefi" suffix on these blocks is a category label, not a hard constraint —
thinkpad-x13s(also a non-UEFI Qualcomm board) is already added to the two desktop blocks under the same convention.Test plan
ufsextension successfully produces UFS-aligned images for both