Skip to content

config.system: add Bianbu to the desktop install menu#893

Merged
igorpecovnik merged 1 commit intomainfrom
config-system-add-bianbu-menu-entry
Apr 24, 2026
Merged

config.system: add Bianbu to the desktop install menu#893
igorpecovnik merged 1 commit intomainfrom
config-system-add-bianbu-menu-entry

Conversation

@igorpecovnik
Copy link
Copy Markdown
Member

@igorpecovnik igorpecovnik commented Apr 24, 2026

Summary

The bianbu desktop (SpacemiT K1 RISC-V) has a complete YAML definition at tools/modules/desktops/yaml/bianbu.yaml — riscv64 on noble/resolute, with the pinned SpacemiT archive (archive.spacemit.com/bianbu/) at priority >1000 — and installs correctly through module_desktops install de=bianbu …. But the DE install menu is populated from hardcoded entries in tools/json/config.system.json, and bianbu was never added. So on an actual riscv64 image, armbian-config has no menu path to Bianbu.

Reported by a user running armbian-config on a riscv64 Armbian image: "why don't I see an option to install Bianbu desktop?" — because the menu entry didn't exist.

Change

Single-item menu entry (BIAN01) alongside the other community DEs (kde-neon, budgie, deepin, enlightenment), matching their [CSC] labelling. Calls module_desktops install de=bianbu tier=mid — mid tier pulls the full desktop (bianbu-desktop, bianbu-desktop-en), the standard utility set (bianbu-standard), and the K1 camera stack (k1x-cam) — SpacemiT's intended out-of-box experience. Minimal would ship only the bare-bones DE + HW enablement, which isn't really useful on its own.

The condition uses module_desktop_supported bianbu, which reads the YAML's architectures: [riscv64] and releases: noble, resolute — so the entry auto-surfaces on riscv64 noble/resolute and auto-hides everywhere else. No extra arch gate needed.

Test plan

  • On riscv64 + noble or resolute → "Install Bianbu [CSC]" appears under System → Desktop
  • On any other arch/release → entry is hidden (arch gate via YAML)
  • Entry runs module_desktops install de=bianbu tier=mid successfully (installs SpacemiT archive + keyring + preferences + mid tier packages)

@github-actions github-actions Bot added 05 Milestone: Second quarter release size/small PR with less then 50 lines labels Apr 24, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

Warning

Rate limit exceeded

@igorpecovnik has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 58 minutes and 48 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 58 minutes and 48 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 046ade45-3039-4be5-b7bd-6c3d09859e14

📥 Commits

Reviewing files that changed from the base of the PR and between ce5db67 and e7bb527.

📒 Files selected for processing (1)
  • tools/json/config.system.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch config-system-add-bianbu-menu-entry

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

bianbu has a complete YAML definition under
tools/modules/desktops/yaml/bianbu.yaml (SpacemiT K1 RISC-V
desktop, riscv64 on noble/resolute, pinned SpacemiT archive)
and wires up through module_desktops install like every other
DE. But the DE install menu is populated from hardcoded entries
in tools/json/config.system.json, and bianbu was simply never
added — so on a riscv64 image there was no way to reach it from
armbian-config.

Add a single-tier entry (tier=mid — full DE + bianbu-standard +
k1x-cam, the intended out-of-box experience) alongside the other
community DEs (kde-neon/budgie/deepin/enlightenment). The
`module_desktop_supported bianbu` condition already gates on the
YAML's architectures list, so the entry auto-hides everywhere
except riscv64 noble/resolute.
@igorpecovnik igorpecovnik force-pushed the config-system-add-bianbu-menu-entry branch from 0b66842 to e7bb527 Compare April 24, 2026 12:21
@igorpecovnik igorpecovnik merged commit 12b6f2a into main Apr 24, 2026
221 of 225 checks passed
@igorpecovnik igorpecovnik deleted the config-system-add-bianbu-menu-entry branch April 24, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release size/small PR with less then 50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant