config.system: add Bianbu to the desktop install menu#893
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 58 minutes and 48 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bianbu has a complete YAML definition under tools/modules/desktops/yaml/bianbu.yaml (SpacemiT K1 RISC-V desktop, riscv64 on noble/resolute, pinned SpacemiT archive) and wires up through module_desktops install like every other DE. But the DE install menu is populated from hardcoded entries in tools/json/config.system.json, and bianbu was simply never added — so on a riscv64 image there was no way to reach it from armbian-config. Add a single-tier entry (tier=mid — full DE + bianbu-standard + k1x-cam, the intended out-of-box experience) alongside the other community DEs (kde-neon/budgie/deepin/enlightenment). The `module_desktop_supported bianbu` condition already gates on the YAML's architectures list, so the entry auto-hides everywhere except riscv64 noble/resolute.
0b66842 to
e7bb527
Compare
Summary
The
bianbudesktop (SpacemiT K1 RISC-V) has a complete YAML definition attools/modules/desktops/yaml/bianbu.yaml— riscv64 on noble/resolute, with the pinned SpacemiT archive (archive.spacemit.com/bianbu/) at priority >1000 — and installs correctly throughmodule_desktops install de=bianbu …. But the DE install menu is populated from hardcoded entries intools/json/config.system.json, andbianbuwas never added. So on an actual riscv64 image,armbian-confighas no menu path to Bianbu.Reported by a user running
armbian-configon a riscv64 Armbian image: "why don't I see an option to install Bianbu desktop?" — because the menu entry didn't exist.Change
Single-item menu entry (
BIAN01) alongside the other community DEs (kde-neon,budgie,deepin,enlightenment), matching their[CSC]labelling. Callsmodule_desktops install de=bianbu tier=mid— mid tier pulls the full desktop (bianbu-desktop,bianbu-desktop-en), the standard utility set (bianbu-standard), and the K1 camera stack (k1x-cam) — SpacemiT's intended out-of-box experience. Minimal would ship only the bare-bones DE + HW enablement, which isn't really useful on its own.The
conditionusesmodule_desktop_supported bianbu, which reads the YAML'sarchitectures: [riscv64]andreleases: noble, resolute— so the entry auto-surfaces on riscv64 noble/resolute and auto-hides everywhere else. No extra arch gate needed.Test plan
module_desktops install de=bianbu tier=midsuccessfully (installs SpacemiT archive + keyring + preferences + mid tier packages)