Conversation
The settings modal retained the active tab (e.g. Storage) across open/close cycles because the component stayed mounted. Force a fresh mount on each open via an incrementing key prop, which resets the tab to Appearance and allows CSS enter animations to replay. Added fade-in animation for the modal and a subtle slide transition when switching tabs. Uses opacity-only keyframes on the modal container to avoid creating a WebKit containing block that would trap the CacheManagerModal fixed overlay.
Custom image selection populated Board and OS but left Manufacturer empty. The cached image reuse flow already set a synthetic manufacturer for display consistency — apply the same pattern in handleCustomImage using the detected board vendor or a generic "Custom" fallback.
The auto-detect board option was editable on all platforms even though it only works on Armbian. Detect the running OS at settings load time via getSystemInfo and getArmbianRelease, and force the setting to disabled with a locked dropdown on non-Armbian systems.
🧪 Test BuildsVersion:
ℹ️ About these builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resetting to Appearance tab and replaying enter animations
synthetic pattern already used by cached image reuse
by detecting the OS at settings load time