fix(cache): switch to sort_by_key for LRU ordering#131
Merged
Conversation
Clippy 1.95 flags the explicit `sort_by` closure as unnecessary_sort_by when the comparator is a plain Ord on a single key. Using sort_by_key is shorter and lets the compiler avoid the extra closure indirection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clippy 1.95 (rust-1.95.0) added the
unnecessary_sort_bylint, which triggers on the explicitsort_byclosure used for the LRU cache ordering incache.rs. Since the comparator is a plainOrdon a singleSystemTimekey, the shortersort_by_keyform is equivalent and lets the compiler skip the extra closure indirection. The previous local toolchain (1.91) didn't ship this lint yet, which is why it only showed up on CI after the last release build.