Remove unused _sourceShapes field from DrawingManager#121
Merged
arnaudleclerc merged 2 commits intoreleases/1.18.0from Mar 10, 2026
Merged
Remove unused _sourceShapes field from DrawingManager#121arnaudleclerc merged 2 commits intoreleases/1.18.0from
_sourceShapes field from DrawingManager#121arnaudleclerc merged 2 commits intoreleases/1.18.0from
Conversation
Merged
…y overhead Co-authored-by: arnaudleclerc <9578038+arnaudleclerc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from review on Releases/1.18.0 PR
Remove unused Mar 10, 2026
_sourceShapes field from DrawingManager
arnaudleclerc
added a commit
that referenced
this pull request
Mar 10, 2026
* Add ability to add and remove shapes from drawing manager data source (#110) * Add Drawing Manager component that can be used to add or remove shapes from drawing manager datasource * Add sample page for adding and removing shapes. * Add tests for DrawingManager. * Upgrade projects to supported .NET versions (net8.0, net9.0, net10.0) (#115) - Drop net6.0 (EOL Nov 2024) and net7.0 (EOL May 2024) - Add net9.0 and net10.0 target frameworks to library and test projects - Update sample project to target net10.0 - Add per-TFM package references for net9.0 and net10.0 - Upgrade bunit from 1.26.64 to 1.37.7 for .NET 9/10 compatibility - Update all CI workflows to set up .NET 8.0, 9.0, and 10.0 SDKs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Enable NuGet publish step in release workflow (#116) Re-enable the commented-out dotnet nuget push step in release.yml. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Trigger release workflow on changes to itself (#117) Add .github/workflows/release.yml to the paths filter so the workflow also runs when the release workflow file itself is modified. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix missing static web assets in NuGet package (#118) The Razor SDK generates the static web assets manifest at dotnet build time. Previously, npm run build (which outputs the JS files to wwwroot/) ran after dotnet build, so the manifest was generated with an empty wwwroot/ and dotnet pack --no-build reused that stale manifest. Fix by moving the npm install/lint/build steps before dotnet restore and dotnet build, ensuring the compiled JS files exist in wwwroot/ when the static web assets manifest is generated. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove unused `_sourceShapes` field from `DrawingManager` (#121) * Initial plan * Remove unused _sourceShapes field from DrawingManager to reduce memory overhead Co-authored-by: arnaudleclerc <9578038+arnaudleclerc@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: arnaudleclerc <9578038+arnaudleclerc@users.noreply.github.com> --------- Co-authored-by: mtech-rherpio <166818039+mtech-rherpio@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: arnaudleclerc <9578038+arnaudleclerc@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_sourceShapesinDrawingManagerwas only ever appended to and reset tonull— never read or queried — causing unbounded memory growth proportional to the number of shapes added.Changes
DrawingManager.cs: Remove_sourceShapesfield, its lazy initialization inAddShapesAsync, theAddRangecall, and thenullreset inClearAsyncDrawingManagerTests.cs: Remove reflection-based internal state assertions and theGetInternalSourceShapeshelper; affected tests now solely verify JS runtime calls🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.