Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
+ Coverage 28.12% 36.26% +8.14%
==========================================
Files 7 7
Lines 288 284 -4
==========================================
+ Hits 81 103 +22
+ Misses 205 176 -29
- Partials 2 5 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Replace github.com/docker/docker/client with github.com/moby/moby/client v0.4.1 - Replace github.com/docker/docker/api with github.com/moby/moby/api v1.54.2 - Completely eliminate all github.com/docker/docker dependencies API changes: - Update to new client API (ContainerListResult, EventsResult) - Use Filters as map[string]map[string]bool instead of filters.Args - Handle IPAddress as netip.Addr instead of string - Use container.InspectResponse instead of ContainerJSON Test data: - Remove invalid port entries from testdata/container.json Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Replace deprecated client.NewClientWithOpts with client.New - Remove deprecated client.WithAPIVersionNegotiation option - Remove unnecessary type conversion events.Action(msg.Action) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add edge case tests for Services function: - Test unknown service ports (no service found) - Test unknown protocol types - Test multiple ports with mixed results - Test empty IP addresses Add helper function createTestContainerWithPorts to reduce code duplication and keep tests under function length limits. Coverage remains at 82.9% - uncovered lines are error paths that cannot be reached with valid moby API types (they validate during JSON unmarshal). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add comprehensive tests covering: - Priority constant values (PriEmerg through PriDebug) - Logf function with various message formats - All priority levels - Edge cases (empty messages, formatted messages) Coverage: 66.7% (uncovered path is panic handler when journald fails, which cannot be easily tested in unit tests) Tests handle environments without systemd/journald gracefully. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add comprehensive tests covering: - ignoreOneoff function with enabled/disabled configurations - Various oneoff label scenarios (True, False, missing, unexpected) - getVersion function - gops function - newEntryGroups constructor - Constants validation Coverage: 12.2% Tests are split into separate functions to meet function length limits. Helper function createTestContainer reduces code duplication. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.