Tests fail on current master

[arokem]

D-173-250-157-207:~  $nosetests pymatbridge
...........................EE.......
======================================================================
ERROR: test_publish.test_convert_mfile
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/arokem/anaconda3/lib/python3.4/site-packages/nose-1.3.4-py3.4.egg/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/Users/arokem/anaconda3/lib/python3.4/site-packages/pymatbridge/tests/test_publish.py", line 44, in test_convert_mfile
    publish.convert_mfile(MFILE)
  File "/Users/arokem/anaconda3/lib/python3.4/site-packages/pymatbridge/publish.py", line 125, in convert_mfile
    lines = mfile_to_lines(mfile)
  File "/Users/arokem/anaconda3/lib/python3.4/site-packages/pymatbridge/publish.py", line 53, in mfile_to_lines
    with open(mfile) as fid:
FileNotFoundError: [Errno 2] No such file or directory: '/Users/arokem/anaconda3/lib/python3.4/site-packages/pymatbridge/tests/test_publish.m'

======================================================================
ERROR: test_publish.test_mfile_to_lines
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/arokem/anaconda3/lib/python3.4/site-packages/nose-1.3.4-py3.4.egg/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/Users/arokem/anaconda3/lib/python3.4/site-packages/pymatbridge/tests/test_publish.py", line 54, in test_mfile_to_lines
    lines = publish.mfile_to_lines(MFILE)
  File "/Users/arokem/anaconda3/lib/python3.4/site-packages/pymatbridge/publish.py", line 53, in mfile_to_lines
    with open(mfile) as fid:
FileNotFoundError: [Errno 2] No such file or directory: '/Users/arokem/anaconda3/lib/python3.4/site-packages/pymatbridge/tests/test_publish.m'

----------------------------------------------------------------------
Ran 36 tests in 205.857s

FAILED (errors=2)
D-173-250-157-207:~  $cd ~/source/python-matlab-bridge/

[arokem]

Seems to me like an installation issue. Looking into it!

[jjangsangy]

It looks the file not found error isn't able to find the .m from your site-packages directory.

FileNotFoundError: [Errno 2] No such file or directory: '/Users/arokem/anaconda3/lib/python3.4/site-packages/pymatbridge/tests/test_publish.m'

I went and checked, and it doesn't look like we don't include the test_publish.m in the PACKAGE_DATA, so they don't get installed in site-packages

https://github.com/arokem/python-matlab-bridge/blob/master/pymatbridge/version.py#L78-L85

Changing it to this and reinstalling should fix the problem.

PACKAGE_DATA = {"pymatbridge": ["matlab/matlabserver.m", "matlab/messenger.*",
                                "matlab/usrprog/*", "matlab/util/*.m",
                                "matlab/util/json_v0.2.2/LICENSE",
                                "matlab/util/json_v0.2.2/README.md",
                                "matlab/util/json_v0.2.2/test/*",
                                "matlab/util/json_v0.2.2/json/*.m",
                                "matlab/util/json_v0.2.2/json/java/*",
                                "tests/*.py", "examples/*.ipynb",
                                "tests/test_publish.m"]}

[arokem]

Yeah - there's already a PR for that:
#185

On Sun, May 3, 2015 at 11:27 PM, Sang Han notifications@github.com wrote:

It looks the file not found error isn't able to find the .m from your
site-packages directory.

FileNotFoundError: [Errno 2] No such file or directory: '/Users/arokem/anaconda3/lib/python3.4/site-packages/pymatbridge/tests/test_publish.m'

I went and checked, and it doesn't look like we include the *.m files in
the package_data from these lines.

https://github.com/arokem/python-matlab-bridge/blob/master/pymatbridge/version.py#L78-L85

—
Reply to this email directly or view it on GitHub
#184 (comment)
.

[jjangsangy]

Cool, didn't see that one.

Actually the reason I brought this up is because the test_publish.py and test_publish.m files are also giving me some build issues as well, but likely for another reason.

Was wondering what the test_convert_mfile, test_lines_to_notebook, and test_mfile_to_lines functions operate?

[arokem]

On Sun, May 3, 2015 at 11:41 PM, Sang Han notifications@github.com wrote:

Cool, didn't see that one.

Actually the reason I brought this up is because the test_publish.py and
test_publish.m files are also giving me some build issues as well, but
likely for another reason.

Was wondering how the test_convert_mfile, test_lines_to_notebook, and
test_mfile_to_lines worked?

The general idea is to process the text in an m file (a script), so that it
renders as a notebook that can be opened in a Jupyter notebook with the
matlab kernel. Does that answer your question?

—
Reply to this email directly or view it on GitHub
#184 (comment)
.

[jjangsangy]

Yes! Thanks, that's perfect high level overview!

[arokem]

Closed through #185