fix: include modified mounted files in generated output (closes #56)#62
Merged
aron-muon merged 1 commit intoMay 7, 2026
Conversation
…muon#56) Previously, _filter_generated_files unconditionally excluded ALL files whose names matched uploaded (mounted) files. This meant that if a user uploaded example.xlsx and the code modified it, the modified file would not appear in the execution output. Changes: - Go runner: add mod_time (Unix timestamp) to FileInfo struct and populate it in HandleList and HandleUpload responses - _detect_generated_files: pass mod_time through to callers - _filter_generated_files: accept execution_start_unix parameter; keep mounted files whose mod_time >= execution start time - Add comprehensive unit tests for the new filtering behavior - Add Go test verifying mod_time presence in file listings
gafda
force-pushed
the
fix-modified-files-not-in-generated-output
branch
from
9d944ea to
dfe3ee8
Compare
aron-muon
approved these changes
May 7, 2026
Owner
aron-muon
left a comment
aron-muon
left a comment
There was a problem hiding this comment.
Perfect! Thank you very much!
|
🎉 This PR is included in version 3.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where files uploaded (mounted) by the user and then modified during code execution were not shown in the generated output. Previously,
_filter_generated_filesalways excluded files matching mounted filenames, so even if a file likeexample.xlsxwas changed by the code, it would not appear in the results.Key changes:
mod_time(Unix timestamp) toFileInfostruct, populates it inHandleListandHandleUploadresponses._detect_generated_filesnow passesmod_timethrough to callers._filter_generated_filesnow accepts anexecution_start_unixparameter and keeps mounted files whosemod_timeis greater than or equal to the execution start time.mod_timeis present in file listings.This ensures that any mounted file modified during execution is correctly included in the output, resolving issue #56.