fix: ensure UpperCaseWord preserves case in Verbatim mode#25
Conversation
Previously, `UpperCaseWord` was forcibly lowercased in `WordsToFormattedCase` when no specific casing option (like `CMScreaming` or `CMWhispering`) was provided. This contradicted the behavior of `AcronymWord` and `ExactCaseWord`, which preserve case in default/Verbatim mode. This commit removes the fallback lowercasing for `UpperCaseWord`, ensuring that `ToSnakeCase` and other formatters produce consistent results when `SmartAcronyms` is disabled (which causes uppercase tokens to be classified as `UpperCaseWord`). Added regression test `TestUpperCaseWord_Verbatim_Bug` in `types_test.go`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixed a bug where
UpperCaseWordtokens were being lowercased by default in formatting functions, inconsistent with other word types in Verbatim mode. This was exposed when usingWithSmartAcronyms(false)in the parser. Added regression test.PR created automatically by Jules for task 17681050273744133828 started by @arran4