Arith #15
Merged
Arith #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Each header in arrayfire has it's own module which reexported later for public exposed API * structs `Array`, `Dim4` has their own source files * `util` module has helper functions needed internally * Modified `constant` to be generic function
Also, implemented `Copy` trait for `Aftype` and `Dim4` structs.
From now on, do the arith operations, users have to do the following ``` let a = randu(Dim4::new(&[4,4,1,1])); let b = &a + 3.5; let c = &a - &b; ``` We can't do just `a+b` because of move semantics limitation. This may be improved later when `Copy` trait can be implemented on Objects with `Drop` trait implemented.
Member
Author
|
@jramapuram Please check out the new stuff and let me know your feedback. Thank you! |
Member
|
Great work @9prady9 ! Give me a few days to work through this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.