Merged
Conversation
hiwllc
force-pushed
the
add-docker
branch
2 times, most recently
from
03abe72 to
e8ac828
Compare
flyingluscas
suggested changes
Sep 13, 2018
| FROM node:8.12.0-alpine | ||
|
|
||
| ARG PRODUCTION | ||
| ENV PRODUCTION ${PRODUCTION:-true} |
There was a problem hiding this comment.
@UselessDev da pra usar stages no dockerfile, assim não precisa desse ARG e ENV para saber se é production ou não, um exemplo disso aqui.
flyingluscas
suggested changes
Sep 14, 2018
|
|
||
| COPY ./.eslintrc.js /api/.eslintrc.js | ||
| COPY ./package.json /api/package.json | ||
| COPY ./server.js /api/server.js |
There was a problem hiding this comment.
@UselessDev por que o eslintrc.js e server.js são copiados mas não são usados no Dockerfile?
Member
Author
There was a problem hiding this comment.
Não tenho certeza 🤔 técnicamente então eu não preciso copiar nenhum arquivo no Dockerfile se ele não for usado?
There was a problem hiding this comment.
se não for usado no Dockerfile não
Member
Author
There was a problem hiding this comment.
No caso do package.json faz sentido deixar ele no Dockerfile?
Merged
hiwllc
force-pushed
the
add-docker
branch
2 times, most recently
from
43a849a to
9fe11da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrição
Este PR adiciona o Dockerfile para produção e docker-compose para desenvolvimento.
Resolve #1