[Fix] Mixpanel: use PaginationStrategy::None so paged queries are not wrapped#25
Merged
Conversation
… wrapped The engine's default SubqueryOffset strategy wrapped user SQL in SELECT * FROM (...) AS _p LIMIT ... OFFSET ..., which the Mixpanel SQL subset parser rejects with 'Missing FROM clause' (derived tables are unsupported). The driver already buffers the full export result, so the engine can page it in memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To fix a query error when using Mixpanel as connection:
MixpanelDriverdid not overridepagination_strategy(), so it inherited the defaultPaginationStrategy::SubqueryOffset. When the console runs a paginated SELECT, the query engine wraps the user SQL in a pagination subquery:SELECT * FROM (SELECT * FROM events LIMIT 100) AS _p LIMIT 501 OFFSET 0The Mixpanel driver's SQL-subset parser only accepts a plain table in the FROM clause; a derived table hits the TableFactor::Table mismatch in get_table_name and surfaces as
Missing FROM clause.Checklist