PHUIPropertyListView

Summary: This builds out and implements PHUIPropertyListView (container) and PHUIPropertyListItemView (section) as well as adding tabs.

Test Plan: Tested each page I edited with the exception of Releeph and Phortune, though those changes look ok to me diff wise. Updated examples page with tabs.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7283

Author: chadlittle

scripts/celerity_mapper.php

@@ -112,7 +112,7 @@
 
     'phabricator-application-launch-view-css',
     'phabricator-action-list-view-css',
-    'phabricator-property-list-view-css',
+    'phui-property-list-view-css',
     'phabricator-tag-view-css',
     'phui-list-view-css',
   ),

src/__celerity_resource_map__.php

@@ -1149,7 +1149,7 @@
   ),
   'diviner-shared-css' =>
   array(
-    'uri' => '/res/cba9c99e/rsrc/css/diviner/diviner-shared.css',
+    'uri' => '/res/2e831eea/rsrc/css/diviner/diviner-shared.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -3387,15 +3387,6 @@
     ),
     'disk' => '/rsrc/css/application/projects/project-tag.css',
   ),
-  'phabricator-property-list-view-css' =>
-  array(
-    'uri' => '/res/31912bb1/rsrc/css/layout/phabricator-property-list-view.css',
-    'type' => 'css',
-    'requires' =>
-    array(
-    ),
-    'disk' => '/rsrc/css/layout/phabricator-property-list-view.css',
-  ),
   'phabricator-remarkup-css' =>
   array(
     'uri' => '/res/7e8988dd/rsrc/css/core/remarkup.css',
@@ -3760,7 +3751,7 @@
   ),
   'phui-document-view-css' =>
   array(
-    'uri' => '/res/40e39942/rsrc/css/phui/phui-document.css',
+    'uri' => '/res/f744b3b2/rsrc/css/phui/phui-document.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -3796,7 +3787,7 @@
   ),
   'phui-header-view-css' =>
   array(
-    'uri' => '/res/94208bd6/rsrc/css/phui/phui-header-view.css',
+    'uri' => '/res/d4cec460/rsrc/css/phui/phui-header-view.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -3848,6 +3839,15 @@
     ),
     'disk' => '/rsrc/css/phui/phui-pinboard-view.css',
   ),
+  'phui-property-list-view-css' =>
+  array(
+    'uri' => '/res/6c937c64/rsrc/css/phui/phui-property-list-view.css',
+    'type' => 'css',
+    'requires' =>
+    array(
+    ),
+    'disk' => '/rsrc/css/phui/phui-property-list-view.css',
+  ),
   'phui-remarkup-preview-css' =>
   array(
     'uri' => '/res/50fa4178/rsrc/css/phui/phui-remarkup-preview.css',
@@ -4220,7 +4220,7 @@
 ), array(
   'packages' =>
   array(
-    '7cd2ded3' =>
+    '09637a26' =>
     array(
       'name' => 'core.pkg.css',
       'symbols' =>
@@ -4265,11 +4265,11 @@
         37 => 'phui-icon-view-css',
         38 => 'phabricator-application-launch-view-css',
         39 => 'phabricator-action-list-view-css',
-        40 => 'phabricator-property-list-view-css',
+        40 => 'phui-property-list-view-css',
         41 => 'phabricator-tag-view-css',
         42 => 'phui-list-view-css',
       ),
-      'uri' => '/res/pkg/7cd2ded3/core.pkg.css',
+      'uri' => '/res/pkg/09637a26/core.pkg.css',
       'type' => 'css',
     ),
     '64eeda79' =>
@@ -4461,15 +4461,15 @@
   ),
   'reverse' =>
   array(
-    'aphront-dialog-view-css' => '7cd2ded3',
-    'aphront-error-view-css' => '7cd2ded3',
-    'aphront-list-filter-view-css' => '7cd2ded3',
-    'aphront-pager-view-css' => '7cd2ded3',
-    'aphront-panel-view-css' => '7cd2ded3',
-    'aphront-table-view-css' => '7cd2ded3',
-    'aphront-tokenizer-control-css' => '7cd2ded3',
-    'aphront-tooltip-css' => '7cd2ded3',
-    'aphront-typeahead-control-css' => '7cd2ded3',
+    'aphront-dialog-view-css' => '09637a26',
+    'aphront-error-view-css' => '09637a26',
+    'aphront-list-filter-view-css' => '09637a26',
+    'aphront-pager-view-css' => '09637a26',
+    'aphront-panel-view-css' => '09637a26',
+    'aphront-table-view-css' => '09637a26',
+    'aphront-tokenizer-control-css' => '09637a26',
+    'aphront-tooltip-css' => '09637a26',
+    'aphront-typeahead-control-css' => '09637a26',
     'differential-changeset-view-css' => '4dc2311c',
     'differential-core-view-css' => '4dc2311c',
     'differential-inline-comment-editor' => '5e9e5c4e',
@@ -4483,7 +4483,7 @@
     'differential-table-of-contents-css' => '4dc2311c',
     'diffusion-commit-view-css' => 'c8ce2d88',
     'diffusion-icons-css' => 'c8ce2d88',
-    'global-drag-and-drop-css' => '7cd2ded3',
+    'global-drag-and-drop-css' => '09637a26',
     'inline-comment-summary-css' => '4dc2311c',
     'javelin-aphlict' => '64eeda79',
     'javelin-behavior' => '9564fa17',
@@ -4558,56 +4558,56 @@
     'javelin-util' => '9564fa17',
     'javelin-vector' => '9564fa17',
     'javelin-workflow' => '9564fa17',
-    'lightbox-attachment-css' => '7cd2ded3',
+    'lightbox-attachment-css' => '09637a26',
     'maniphest-task-summary-css' => '49898640',
-    'phabricator-action-list-view-css' => '7cd2ded3',
-    'phabricator-application-launch-view-css' => '7cd2ded3',
+    'phabricator-action-list-view-css' => '09637a26',
+    'phabricator-application-launch-view-css' => '09637a26',
     'phabricator-busy' => '64eeda79',
     'phabricator-content-source-view-css' => '4dc2311c',
-    'phabricator-core-css' => '7cd2ded3',
-    'phabricator-crumbs-view-css' => '7cd2ded3',
+    'phabricator-core-css' => '09637a26',
+    'phabricator-crumbs-view-css' => '09637a26',
     'phabricator-drag-and-drop-file-upload' => '5e9e5c4e',
     'phabricator-dropdown-menu' => '64eeda79',
     'phabricator-file-upload' => '64eeda79',
-    'phabricator-filetree-view-css' => '7cd2ded3',
-    'phabricator-flag-css' => '7cd2ded3',
+    'phabricator-filetree-view-css' => '09637a26',
+    'phabricator-flag-css' => '09637a26',
     'phabricator-hovercard' => '64eeda79',
-    'phabricator-jump-nav' => '7cd2ded3',
+    'phabricator-jump-nav' => '09637a26',
     'phabricator-keyboard-shortcut' => '64eeda79',
     'phabricator-keyboard-shortcut-manager' => '64eeda79',
-    'phabricator-main-menu-view' => '7cd2ded3',
+    'phabricator-main-menu-view' => '09637a26',
     'phabricator-menu-item' => '64eeda79',
-    'phabricator-nav-view-css' => '7cd2ded3',
+    'phabricator-nav-view-css' => '09637a26',
     'phabricator-notification' => '64eeda79',
-    'phabricator-notification-css' => '7cd2ded3',
-    'phabricator-notification-menu-css' => '7cd2ded3',
+    'phabricator-notification-css' => '09637a26',
+    'phabricator-notification-menu-css' => '09637a26',
     'phabricator-object-selector-css' => '4dc2311c',
     'phabricator-phtize' => '64eeda79',
     'phabricator-prefab' => '64eeda79',
     'phabricator-project-tag-css' => '49898640',
-    'phabricator-property-list-view-css' => '7cd2ded3',
-    'phabricator-remarkup-css' => '7cd2ded3',
+    'phabricator-remarkup-css' => '09637a26',
     'phabricator-shaped-request' => '5e9e5c4e',
-    'phabricator-side-menu-view-css' => '7cd2ded3',
-    'phabricator-standard-page-view' => '7cd2ded3',
-    'phabricator-tag-view-css' => '7cd2ded3',
+    'phabricator-side-menu-view-css' => '09637a26',
+    'phabricator-standard-page-view' => '09637a26',
+    'phabricator-tag-view-css' => '09637a26',
     'phabricator-textareautils' => '64eeda79',
     'phabricator-tooltip' => '64eeda79',
-    'phabricator-transaction-view-css' => '7cd2ded3',
-    'phabricator-zindex-css' => '7cd2ded3',
-    'phui-button-css' => '7cd2ded3',
-    'phui-form-css' => '7cd2ded3',
-    'phui-form-view-css' => '7cd2ded3',
-    'phui-header-view-css' => '7cd2ded3',
-    'phui-icon-view-css' => '7cd2ded3',
-    'phui-list-view-css' => '7cd2ded3',
-    'phui-object-item-list-view-css' => '7cd2ded3',
-    'phui-spacing-css' => '7cd2ded3',
-    'sprite-apps-large-css' => '7cd2ded3',
-    'sprite-gradient-css' => '7cd2ded3',
-    'sprite-icons-css' => '7cd2ded3',
-    'sprite-menu-css' => '7cd2ded3',
-    'sprite-status-css' => '7cd2ded3',
-    'syntax-highlighting-css' => '7cd2ded3',
+    'phabricator-transaction-view-css' => '09637a26',
+    'phabricator-zindex-css' => '09637a26',
+    'phui-button-css' => '09637a26',
+    'phui-form-css' => '09637a26',
+    'phui-form-view-css' => '09637a26',
+    'phui-header-view-css' => '09637a26',
+    'phui-icon-view-css' => '09637a26',
+    'phui-list-view-css' => '09637a26',
+    'phui-object-item-list-view-css' => '09637a26',
+    'phui-property-list-view-css' => '09637a26',
+    'phui-spacing-css' => '09637a26',
+    'sprite-apps-large-css' => '09637a26',
+    'sprite-gradient-css' => '09637a26',
+    'sprite-icons-css' => '09637a26',
+    'sprite-menu-css' => '09637a26',
+    'sprite-status-css' => '09637a26',
+    'syntax-highlighting-css' => '09637a26',
   ),
 ));

src/__phutil_library_map__.php

@@ -788,6 +788,9 @@
     'PHUIPagedFormView' => 'view/form/PHUIPagedFormView.php',
     'PHUIPinboardItemView' => 'view/phui/PHUIPinboardItemView.php',
     'PHUIPinboardView' => 'view/phui/PHUIPinboardView.php',
+    'PHUIPropertyGroupView' => 'view/phui/PHUIPropertyGroupView.php',
+    'PHUIPropertyListExample' => 'applications/uiexample/examples/PHUIPropertyListExample.php',
+    'PHUIPropertyListView' => 'view/phui/PHUIPropertyListView.php',
     'PHUIRemarkupPreviewPanel' => 'view/phui/PHUIRemarkupPreviewPanel.php',
     'PHUIStatusItemView' => 'view/phui/PHUIStatusItemView.php',
     'PHUIStatusListView' => 'view/phui/PHUIStatusListView.php',
@@ -1524,8 +1527,6 @@
     'PhabricatorProjectTransaction' => 'applications/project/storage/PhabricatorProjectTransaction.php',
     'PhabricatorProjectTransactionType' => 'applications/project/constants/PhabricatorProjectTransactionType.php',
     'PhabricatorProjectUpdateController' => 'applications/project/controller/PhabricatorProjectUpdateController.php',
-    'PhabricatorPropertyListExample' => 'applications/uiexample/examples/PhabricatorPropertyListExample.php',
-    'PhabricatorPropertyListView' => 'view/layout/PhabricatorPropertyListView.php',
     'PhabricatorQuery' => 'infrastructure/query/PhabricatorQuery.php',
     'PhabricatorRecaptchaConfigOptions' => 'applications/config/option/PhabricatorRecaptchaConfigOptions.php',
     'PhabricatorRedirectController' => 'applications/base/controller/PhabricatorRedirectController.php',
@@ -2926,6 +2927,9 @@
     'PHUIPagedFormView' => 'AphrontTagView',
     'PHUIPinboardItemView' => 'AphrontView',
     'PHUIPinboardView' => 'AphrontView',
+    'PHUIPropertyGroupView' => 'AphrontTagView',
+    'PHUIPropertyListExample' => 'PhabricatorUIExample',
+    'PHUIPropertyListView' => 'AphrontView',
     'PHUIRemarkupPreviewPanel' => 'AphrontTagView',
     'PHUIStatusItemView' => 'AphrontTagView',
     'PHUIStatusListView' => 'AphrontTagView',
@@ -3726,8 +3730,6 @@
     'PhabricatorProjectTransaction' => 'PhabricatorProjectDAO',
     'PhabricatorProjectTransactionType' => 'PhabricatorProjectConstants',
     'PhabricatorProjectUpdateController' => 'PhabricatorProjectController',
-    'PhabricatorPropertyListExample' => 'PhabricatorUIExample',
-    'PhabricatorPropertyListView' => 'AphrontView',
     'PhabricatorRecaptchaConfigOptions' => 'PhabricatorApplicationConfigOptions',
     'PhabricatorRedirectController' => 'PhabricatorController',
     'PhabricatorRefreshCSRFController' => 'PhabricatorAuthController',

src/applications/config/controller/PhabricatorConfigAllController.php

@@ -66,15 +66,15 @@ public function processRequest() {
 
     $versions = $this->loadVersions();
 
-    $version_property_list = id(new PhabricatorPropertyListView());
+    $version_property_list = id(new PHUIPropertyListView());
     foreach ($versions as $version) {
       list($name, $hash) = $version;
       $version_property_list->addProperty($name, $hash);
     }
 
     $object_box = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Current Settings'))
-      ->setPropertyList($version_property_list);
+      ->addPropertyList($version_property_list);
 
     $phabricator_root = dirname(phutil_get_library_root('phabricator'));
     $version_path = $phabricator_root.'/conf/local/VERSION';

src/applications/countdown/controller/PhabricatorCountdownViewController.php

@@ -45,12 +45,11 @@ public function processRequest() {
       ->setHeader($title);
 
     $actions = $this->buildActionListView($countdown);
-    $properties = $this->buildPropertyListView($countdown);
+    $properties = $this->buildPropertyListView($countdown, $actions);
 
     $object_box = id(new PHUIObjectBoxView())
       ->setHeader($header)
-      ->setActionList($actions)
-      ->setPropertyList($properties);
+      ->addPropertyList($properties);
 
     $content = array(
       $crumbs,
@@ -99,14 +98,18 @@ private function buildActionListView(PhabricatorCountdown $countdown) {
     return $view;
   }
 
-  private function buildPropertyListView(PhabricatorCountdown $countdown) {
+  private function buildPropertyListView(
+    PhabricatorCountdown $countdown,
+    PhabricatorActionListView $actions) {
+
     $request = $this->getRequest();
     $viewer = $request->getUser();
 
     $this->loadHandles(array($countdown->getAuthorPHID()));
 
-    $view = id(new PhabricatorPropertyListView())
-      ->setUser($viewer);
+    $view = id(new PHUIPropertyListView())
+      ->setUser($viewer)
+      ->setActionList($actions);
 
     $view->addProperty(
       pht('Author'),

src/applications/daemon/controller/PhabricatorDaemonLogViewController.php

@@ -72,11 +72,14 @@ public function processRequest() {
     $event_panel->setNoBackground();
     $event_panel->appendChild($event_view);
 
+    $object_box = id(new PHUIObjectBoxView())
+      ->setHeader($header)
+      ->addPropertyList($properties);
+
     return $this->buildApplicationPage(
       array(
         $crumbs,
-        $header,
-        $properties,
+        $object_box,
         $event_panel,
       ),
       array(
@@ -88,7 +91,7 @@ private function buildPropertyListView(PhabricatorDaemonLog $daemon) {
     $request = $this->getRequest();
     $viewer = $request->getUser();
 
-    $view = id(new PhabricatorPropertyListView())
+    $view = id(new PHUIPropertyListView())
       ->setUser($viewer);
 
     $id = $daemon->getID();

src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php

@@ -38,18 +38,20 @@ public function processRequest() {
           $task->getID(),
           $task->getTaskClass()));
 
-      $actions    = $this->buildActionListView($task);
-      $properties = $this->buildPropertyListView($task);
+      $actions = $this->buildActionListView($task);
+      $properties = $this->buildPropertyListView($task, $actions);
 
       $retry_head = id(new PHUIHeaderView())
         ->setHeader(pht('Retries'));
 
       $retry_info = $this->buildRetryListView($task);
 
+      $object_box = id(new PHUIObjectBoxView())
+        ->setHeader($header)
+        ->addPropertyList($properties);
+
       $content = array(
-        $header,
-        $actions,
-        $properties,
+        $object_box,
         $retry_head,
         $retry_info,
       );
@@ -114,8 +116,12 @@ private function buildActionListView(PhabricatorWorkerTask $task) {
     return $view;
   }
 
-  private function buildPropertyListView(PhabricatorWorkerTask $task) {
-    $view = new PhabricatorPropertyListView();
+  private function buildPropertyListView(
+    PhabricatorWorkerTask $task,
+    PhabricatorActionListView $actions) {
+
+    $view = new PHUIPropertyListView();
+    $view->setActionList($actions);
 
     if ($task->isArchived()) {
       switch ($task->getResult()) {
@@ -197,7 +203,7 @@ private function buildPropertyListView(PhabricatorWorkerTask $task) {
   }
 
   private function buildRetryListView(PhabricatorWorkerTask $task) {
-    $view = new PhabricatorPropertyListView();
+    $view = new PHUIPropertyListView();
 
     $data = id(new PhabricatorWorkerTaskData())->load($task->getDataID());
     $task->setData($data->getData());

src/applications/differential/controller/DifferentialDiffViewController.php

@@ -117,7 +117,7 @@ public function processRequest() {
     $property_head = id(new PHUIHeaderView())
       ->setHeader(pht('Properties'));
 
-    $property_view = new PhabricatorPropertyListView();
+    $property_view = new PHUIPropertyListView();
     foreach ($dict as $key => $value) {
       $property_view->addProperty($key, $value);
     }