Improve bookkeeping logging and performance#197
Merged
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…sion character class' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…rt-daq/artdaq-daqinterface into eflumerf/LoggingAndPerformance
rrivera747
approved these changes
Apr 21, 2026
Contributor
rrivera747
left a comment
rrivera747
left a comment
There was a problem hiding this comment.
Looks good to me - Calorimeter ran with these changes with minimal issues.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on improving observability and speeding up DAQInterface “bookkeeping” by adding more granular timing logs and reducing repeated/expensive computations during FHiCL document processing.
Changes:
- Add timestamped debug logging to process-launch and transition-sending paths.
- Optimize
bookkeeping_for_fhicl_documents_artdaq_v3_basevia precompiled regexes, memoization, and hoisting repeated lookups. - Parallelize private-network discovery across hosts using a thread pool.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
rc/control/manage_processes_direct.py |
Adds timestamp prefixes to selected debug logs during launch on a host. |
rc/control/daqinterface.py |
Adds elapsed-time debug logging around per-process transition sending. |
rc/control/bookkeeping.py |
Major performance refactor: precompiled regexes, caching, reduced repeated scans, parallel network discovery, and additional timing logs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/art-daq/artdaq-daqinterface/sessions/bf139e9b-0d87-4204-b40e-5233c2829756 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>
Agent-Logs-Url: https://github.com/art-daq/artdaq-daqinterface/sessions/bf139e9b-0d87-4204-b40e-5233c2829756 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>
github-project-automation
Bot
moved this from 👍 PR Created
to 🎉 Done
in art-daq Work Tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.