Fixed remote active sessions and large available space#312
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses two distinct issues: adding remote active sessions to the user tracking system and converting disk space units from KB to GB in XML output to improve readability for large storage systems.
Changes:
- Added remote session users to the active users string in WebUsers functionality
- Converted available disk space reporting from KB to GB in GatewaySupervisor XML outputs for both main apps and subapps
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| otsdaq/WebUsersUtilities/WebUsers.cc | Added iteration over RemoteSessions_ to include remote session users in the active users string |
| otsdaq/GatewaySupervisor/GatewaySupervisor.cc | Renamed XML fields from availableLogSpaceKB/availableDataSpaceKB to GB equivalents and converted values using decimal unit conversion (÷1000÷1000) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@rrivera747 I've opened a new pull request, #314, to work on those changes. Once the pull request is ready, I'll request review from you. |
Contributor
|
@rrivera747 I've opened a new pull request, #315, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Clarify 32-bit integer overflow as reason for KB to GB conversion
Fix getActiveUserCount to include remote sessions
eflumerf
approved these changes
Jan 30, 2026
eflumerf
deleted the
rrivera/fixRemoteActiveSessionsAndLargeAvailableSpace
branch
github-project-automation
bot
moved this from 👍 PR Created
to 🎉 Done
in art-daq Work Tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.