Skip to content

Add explicit include for uintptr_t in StringMacros.cc#323

Merged
rrivera747 merged 2 commits intorrivera/implementSystemVarsAndConfigTransitionConsolidatefrom
copilot/sub-pr-320-another-one
Feb 9, 2026
Merged

Add explicit include for uintptr_t in StringMacros.cc#323
rrivera747 merged 2 commits intorrivera/implementSystemVarsAndConfigTransitionConsolidatefrom
copilot/sub-pr-320-another-one

Conversation

Copy link
Contributor

Copilot AI commented Feb 9, 2026

Addresses feedback from PR #320 to add proper header declaration for uintptr_t type used in address math helper functions.

Changes

  • Added #include <cstdint> to otsdaq/Macros/StringMacros.cc to explicitly declare uintptr_t instead of relying on transitive includes

The type is used in find_library_base() and resolve_stack_entry() for pointer arithmetic when resolving stack traces:

#include "otsdaq/Macros/StringMacros.h"

#include <algorithm>  // for find_if
#include <array>
#include <cstdint>    // for uintptr_t

using namespace ots;

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Copilot AI changed the title [WIP] Update based on review feedback for system vars transition Add explicit include for uintptr_t in StringMacros.cc Feb 9, 2026
Copilot AI requested a review from rrivera747 February 9, 2026 18:10
@rrivera747 rrivera747 marked this pull request as ready for review February 9, 2026 21:26
@rrivera747 rrivera747 merged commit 9cde218 into rrivera/implementSystemVarsAndConfigTransitionConsolidate Feb 9, 2026
@rrivera747 rrivera747 deleted the copilot/sub-pr-320-another-one branch February 9, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants