Add explicit include for uintptr_t in StringMacros.cc#323
Merged
rrivera747 merged 2 commits intorrivera/implementSystemVarsAndConfigTransitionConsolidatefrom Feb 9, 2026
Conversation
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update based on review feedback for system vars transition
Add explicit include for uintptr_t in StringMacros.cc
Feb 9, 2026
9cde218
into
rrivera/implementSystemVarsAndConfigTransitionConsolidate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from PR #320 to add proper header declaration for
uintptr_ttype used in address math helper functions.Changes
#include <cstdint>tootsdaq/Macros/StringMacros.ccto explicitly declareuintptr_tinstead of relying on transitive includesThe type is used in
find_library_base()andresolve_stack_entry()for pointer arithmetic when resolving stack traces:✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.