ARTDAQSupervisor: improved python error propagation#343
Merged
rrivera747 merged 8 commits intodevelopfrom Feb 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves Python error propagation in the ARTDAQSupervisor component by replacing direct error printing with structured error capture and propagation mechanisms. The changes enable better error diagnostics and debugging when Python/C API calls fail during DAQInterface initialization and operation.
Changes:
- Replaced
PyErr_Print()calls withcheckPythonError()+capturePyErr()pattern for better error capture - Added error handling for DAQInterface constructor failures
- Added defensive null pointer check before using daqinterface_ptr_
- Modified
captureStderrAndStdout_()to preserve pending Python errors - Added MongoDB certificate file validation in startup script
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/ots | Added MongoDB certificate validation checks and minor whitespace adjustment |
| otsdaq/ARTDAQSupervisor/ARTDAQSupervisor.cc | Improved Python error handling throughout - replaced PyErr_Print() with capturePyErr(), added DAQInterface constructor error checking, added null pointer safety check, and prevented error consumption in captureStderrAndStdout_() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…art-daq/otsdaq into sc/ARTDAQSupervisorPythonErrors
…art-daq/otsdaq into sc/ARTDAQSupervisorPythonErrors
rrivera747
approved these changes
Feb 19, 2026
Contributor
rrivera747
left a comment
There was a problem hiding this comment.
Looks good (after whitespace cleanup)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…art-daq/otsdaq into sc/ARTDAQSupervisorPythonErrors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More work on python error propagation - I think this was really limiting us in today's efforts