Merged
Conversation
…for consumer configuration
…QoS and graceful shutdown
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Implements RabbitMQ message consumer for receiving and processing messages from queues as defined in issue #50.
Closes #50
🎯 Implementation
This PR implements:
1. RabbitMqConsumer (
src/StarGate.Infrastructure/Messaging/RabbitMQ/RabbitMqConsumer.cs)IMessageConsumerusingAsyncEventingBasicConsumerfor async message processingMessageContext.AcknowledgeAsyncandMessageContext.RejectAsyncdelegatesPrefetchCount(default: 10)OperationCanceledException→ requeue for another workerAlreadyClosedExceptionhandling for closed channelsSemaphoreSlimfor consumer lifecycleIAsyncDisposablefor proper resource cleanup2. NullMessageConsumer (
src/StarGate.Infrastructure/Messaging/NullMessageConsumer.cs)3. RabbitMqOptions extension
PrefetchCountproperty (default: 10) for QoS configurationShutdownGracePeriodMsproperty (default: 1000) for graceful shutdown4. Dependency Injection update
IMessageConsumeras singletonRabbitMqConsumerwhen RabbitMQ is enabledNullMessageConsumerwhen RabbitMQ is disabled✅ Acceptance Criteria
RabbitMqConsumerimplementsIMessageConsumerinterfaceAsyncEventingBasicConsumerMessageContextdelegates (existing design)RejectAsync(requeue: true)PrefetchCountNullMessageConsumerfallback when RabbitMQ disabledIAsyncDisposable)📝 Notes
Design Alignment
This implementation follows the existing project design where acknowledgment is handled via
MessageContextdelegates (AcknowledgeAsync/RejectAsync) rather than theMessageHandlingResultenum proposed in the original issue description. This maintains consistency with the currentIMessageConsumerinterface andMessageContextabstraction.Key Differences from Issue Proposal
MessageContextdelegates instead of returningMessageHandlingResultenumstargate.{typename}Testing
Unit tests will be added in a follow-up PR. Integration tests are tracked in issue #35.
🔗 Related Issues