docs: clarify base branch strategy in CONTRIBUTING.md#80
Merged
Conversation
Closes #79 - Add explicit rule to always branch off from `develop` - Update Development Setup git example to start from develop - Add PR checklist item: PR targets develop (not master) - Add approval step to Documentation Improvements workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #79
Updates
CONTRIBUTING.mdto explicitly state that all contributions must branch off fromdevelop, never frommaster. This applies to all contribution types, including documentation-only changes.Changes
developexplicitlygit checkoutexample to start fromdevelopwithgit pull upstream developdevelop(notmaster)develop(notmaster)Motivation
Three recent PRs (#75, #76, #77) demonstrated that contributors were unclear about the expected base branch. Two out of three targeted
masterdirectly. This change makes the rule unambiguous for all future contributors.Notes
Documentation-only change. No code or test files modified.