Merged
Conversation
hugovasselin
suggested changes
Jun 3, 2021
Contributor
hugovasselin
left a comment
hugovasselin
left a comment
There was a problem hiding this comment.
Bravo Sacha hyper propre ! A part une petite coquille dans le readme pas grand chose à changer mais plutôt des pistes de réflexions :)
Notamment la dépendance à Dask obligatoire ca peut rendre la lib plus lourde et compliquée à installer
Contributor
|
C'est parfait Sacha merci!! Est-ce qu'on peut juste upgrade la version avant de merge ? |
rafaelleaygalenq
approved these changes
Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a class to easily load text data using Dask, whether it is stored locally or on GCS. The TextLoader class can be fetched with a single path, but also with a list of path, that may contain wildcards