Skip to content

[Test] added test to check regex validation of spacy model name#165

Merged
Cedric-Magnan merged 2 commits intomainfrom
test/tokenizer_load_validation
Sep 16, 2021
Merged

[Test] added test to check regex validation of spacy model name#165
Cedric-Magnan merged 2 commits intomainfrom
test/tokenizer_load_validation

Conversation

@Cedric-Magnan
Copy link
Copy Markdown
Contributor

Description

I've removed a test on tokenizer.py when changing to Poetry by automatically loading spacy models when they are not available in the environment.
I now add a test on tokenizer.py to check if model names are well validated and that hackers can't execute malicious code with NLPretext !

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Cedric-Magnan Cedric-Magnan merged commit 6c618cc into main Sep 16, 2021
@Cedric-Magnan Cedric-Magnan deleted the test/tokenizer_load_validation branch September 16, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant