Fix csp violation breaking “back to previous page” link #2233

Eashana0104 · 2025-11-19T20:12:13Z

Closes #2232

Changes Made -

Extracted inline back-navigation JS into an external file for CSP compliance.
Added a new back-navigation handler with proper history and fallback behavior.
Updated all templates that previously relied on inline JavaScript for the Back to previous page link to use the new external script.

Clicking on Back to previous page

No more CSP compliance errors on clicking Back to previous page

Leads back to the previous page in history.

…ass selector for all files using it for back navigation

sarah-mason · 2025-11-20T17:36:42Z

Hi @Eashana0104! Thank you so much for your contribution and congratulations on your first PR to AtoM! I'm know you are getting your development environment set up still, but the Prettier test failed. Everything else passed!

melaniekung

Hi @Eashana0104 , thanks for the contribution! Just added some small feedback, but otherwise looks great!

melaniekung · 2025-11-21T20:51:47Z

apps/qubit/modules/admin/templates/error404Success.php

-        <a href="javascript:history.go(-1)">
-          <?php echo __('Back to previous page.'); ?>
-        </a><br>
+        <a href="#" class="js-back-link"  data-fallback-url="<?php echo url_for('@homepage'); ?>"><?php echo __('Back to previous page'); ?></a><br>


We should use a data-action like data-action="back" instead of a class to call the js function for better readability. (Same for all the other php classes)

This does increase the readability. I have resolved this in my commits and formatted the closing tags properly to increase readability further!

melaniekung · 2025-11-21T20:53:08Z

js/historyNavigation.js

+  });
+
+  function historyNavigation() {
+    document.querySelectorAll('.js-back-link').forEach(function (el) {


Using a data-action will require updating the querySelectorAll here, but should work with the rest of the function as is.

This makes sense in accordance to the change on selector. Resolved by 52deaf9

melaniekung · 2025-11-21T20:55:28Z

plugins/arDominionB5Plugin/js/main.js

 import "/js/deletePhysicalStorage";
 import "/js/settingsFindingAid";
 import "/js/refreshJobs";
+import "/js/historyNavigation";


Daniel has mentioned to us that you are having troubles setting up prettier checks so I thought it may be useful to add this - I believe the Prettier test may be failing due to the missing empty line here.

The Prettier check was failing due to some formatting requirement failing in historyNavigation.js. i have fixed that using the command prettier --write js/historyNavigation.js. Now all the .js files are formatted according to Prettier rules. Resolved by 5f7db10

…bility

…“Back-to-Previous-Page”-Link

…ious-Page”-Link' of https://github.com/Eashana0104/atom into dev/issue-2232-Fix-CSP-Violation-Breaking-“Back-to-Previous-Page”-Link

…er readability" This reverts commit 8f51f8f.

…bility

…rSuccess.php

melaniekung

Thanks for the updates @Eashana0104 , this looks good to me! Congrats on completing your first PR to AtoM!

anvit

Added a couple small comments

anvit · 2025-11-26T00:28:25Z

js/historyNavigation.js

+  "use strict";
+
+  $(() => {
+    historyNavigation();


I would suggest putting the body of the entire function here instead of a single named function call

Resolved by b84114c

anvit · 2025-11-26T00:34:08Z

js/historyNavigation.js

+          window.history.back();
+        } else {


It would be cleaner to just return; after the window.history.back(); and skip the else entirely.

Resolved by 0476724

This reverts commit f027fc3.

anvit

Thanks @Eashana0104 ! This looks good!

…“Back-to-Previous-Page”-Link

Ash Singhal added 2 commits November 19, 2025 13:22

Add external js for handling back navigation

56a50c3

Change inline javascript to external javascript using js-back-link cl…

7216d6b

…ass selector for all files using it for back navigation

Eashana0104 changed the title ~~Dev/issue 2232 fix csp violation breaking “back to previous page” link~~ Fix csp violation breaking “back to previous page” link Nov 19, 2025

sarah-mason added the Community Pull requests that have been contributed from community members outside Artefactual label Nov 20, 2025

melaniekung requested changes Nov 21, 2025

View reviewed changes

Ash Singhal and others added 12 commits November 24, 2025 12:34

Replace class="js-back-link" to data-action = "back" for better reada…

8f51f8f

…bility

Update querySelector to select based on the correct attribute

52deaf9

Merge branch 'qa/2.x' into dev/issue-2232-Fix-CSP-Violation-Breaking-…

5427ca1

…“Back-to-Previous-Page”-Link

Merge branch 'dev/issue-2232-Fix-CSP-Violation-Breaking-“Back-to-Prev…

b8f73c5

…ious-Page”-Link' of https://github.com/Eashana0104/atom into dev/issue-2232-Fix-CSP-Violation-Breaking-“Back-to-Previous-Page”-Link

Revert "Replace class="js-back-link" to data-action = "back" for bett…

a6133cf

…er readability" This reverts commit 8f51f8f.

Replace class="js-back-link" to data-action = "back" for better reada…

72f1a4d

…bility

Fix unfixed change to data-action

e97d80a

Undo extra changes made to error.html.php

a997db0

Fix prettier issues in historyNavigation.js

5f7db10

Fix formatting of closing tags for better readability

c294977

Fix formatting of missing closing tags for better readability in erro…

d7c23ba

…rSuccess.php

Fix formatting of missing closing tags for better readability in erro…

bc1488c

…rSuccess.php

Eashana0104 requested a review from melaniekung November 24, 2025 22:51

danloveg mentioned this pull request Nov 25, 2025

Problem: Refresh page links violate CSP #2239

Closed

melaniekung approved these changes Nov 25, 2025

View reviewed changes

anvit requested changes Nov 26, 2025

View reviewed changes

Ash Singhal added 4 commits December 1, 2025 11:59

Remove new function creation and putting the code directly for execution

b84114c

Exit the function early by using return statement

f027fc3

Revert "Exit the function early by using return statement"

7d0edfe

This reverts commit f027fc3.

Exit the function early by using return statement

0476724

Eashana0104 requested a review from anvit December 1, 2025 18:20

anvit approved these changes Dec 1, 2025

View reviewed changes

Merge branch 'qa/2.x' into dev/issue-2232-Fix-CSP-Violation-Breaking-…

f188d3a

…“Back-to-Previous-Page”-Link

anvit merged commit eb3187a into artefactual:qa/2.x Dec 2, 2025
6 checks passed

anvit added this to the 2.10.1 milestone Dec 3, 2025

Fix csp violation breaking “back to previous page” link #2233

Fix csp violation breaking “back to previous page” link #2233

Uh oh!

Conversation

Eashana0104 commented Nov 19, 2025

Uh oh!

sarah-mason commented Nov 20, 2025

Uh oh!

melaniekung left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Eashana0104 Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Eashana0104 Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melaniekung left a comment

Choose a reason for hiding this comment

Uh oh!

anvit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anvit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Eashana0104 Nov 24, 2025 •

edited

Loading

Eashana0104 Nov 24, 2025 •

edited

Loading