Refactor and test parts of core logic #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
message_generatorpackageMessageGeneratorconfigpackage, added interimcommitConfigDTOstruct for unmarshalling JSON:we don't need to have pointers in the
CommitConfigafter we detect all unset properties and replace them with default values, but the""are valid values (except for the regex, but I'll work on that later)ospackage withFileReadinginterface, created a simpleFileReaderfacade to just execute the same calls, and added aFileReadingMockto be used in unit testsconfigcreation, from file or default propertiesMakefileto run all tests from all the packages onmake testcommandWhat's Next:
There's much more refactoring left to do and more tests to write, I might get back to it in the future. Maybe I'll also add some step for code coverage.
I also want to add a simpler installation script and more safe-guards against some edge cases where the config file has invalid input.