Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the commit CLI to correctly support commits made from linked Git worktrees by using go-git’s common .git directory support, and adds an end-to-end test to cover committing from a linked worktree. It also includes minor whitespace cleanups and removes an unused constant.
Changes:
- Update repository opening and HEAD/branch detection to work in linked worktrees (
EnableDotGitCommonDir, useplumbing.HEADreference). - Add an e2e test that creates a linked worktree and commits from it.
- Clean up whitespace and remove an unused helper constant.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
cmd/commit/main.go |
Opens repos with support for common git dirs and derives branch name via go-git refs (worktree-compatible). |
e2e.sh |
Adds a linked-worktree commit test and a helper for removing worktrees; whitespace normalization. |
internal/helpers/constants.go |
Removes now-unused HEAD_REF_PREFIX constant. |
docs/README.md |
Whitespace cleanup in JSON example (but reveals a JSON validity issue). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR: