test: add dbsafeString coverage#97
Open
romankonz wants to merge 2 commits intofix/phpstanfrom
Open
Conversation
Adds a table-driven test covering scalar/null/bool passthrough, htmlspecialchars/addslashes flag toggles, and the BackedEnum and EscapeableParameterInterface unwrap branches added in #96. Test fixtures live under tests/Fixtures/. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds four rows verifying that htmlSpecialChars=false / addSlashes=false are still honored when the value arrives via a BackedEnum or EscapeableParameterInterface, without relying on the implementation joining the post-unwrap path with the plain-string path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testDbsafeStringtoConnectionTestwith 19 table-driven cases.BackedEnum,EscapeableParameterInterface).tests/Fixtures/StringBackedEnum.php,IntBackedEnum.php,EscapeableValue.php.Base branch is #96 (
fix/phpstan); merge that first.🤖 Generated with Claude Code