[AI-assisted] Gateway: keep browser control in minimal startup#115
Merged
Merged
Conversation
- what: backport the sidecar startup policy helper and test so minimal startup keeps browser control enabled while still skipping the heavier sidecars - why: minimal startup without browser control makes browser requests fail for fake reasons and hides the real runtime state - risk: low; only affects minimal-startup policy and is covered by targeted tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
OPENCLAW_SKIP_BROWSER_CONTROL_SERVER=1still wins.Security Impact (required)
Yes/No)Yes/No)Yes/No)Yes/No)Yes/No)Yes, explain risk + mitigation:Repro + Verification
Environment
Steps
OPENCLAW_CONSUMER_MINIMAL_STARTUP=1.Expected
skipBrowserControlstaysfalsefor minimal startup alone.skipBrowserControlflips totrueonly whenOPENCLAW_SKIP_BROWSER_CONTROL_SERVER=1is set.Actual
Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
pnpm test -- src/gateway/server-startup.test.tspnpm build/pnpm checkonmainReview Conversations
Compatibility / Migration
Yes/No)Yes/No)Yes/No)Failure Recovery (if this breaks)
7087f93a2a554d65bda02ea3017a99620c7fc9aesrc/gateway/server-startup.tssrc/gateway/server-startup.test.tsRisks and Mitigations
AI Assistance