Skip to content

fix: restore local validation gates#125

Merged
artemgetmann merged 1 commit into
mainfrom
claude/tsgo-cleanup-batch1-20260325
Mar 25, 2026
Merged

fix: restore local validation gates#125
artemgetmann merged 1 commit into
mainfrom
claude/tsgo-cleanup-batch1-20260325

Conversation

@artemgetmann
Copy link
Copy Markdown
Owner

Review Fast Path

  • User path fixed: local repo validation after the docs cleanup no longer dies on stale type fixtures, stale plugin SDK imports, or an obsolete browser relay test.
  • Proof: pnpm build ✅, pnpm check ✅, targeted tests passed for src/wizard/setup.test.ts, src/commands/agent/session.test.ts, extensions/telegram/src/channel.test.ts, extensions/telegram/src/thread-session-seeding.test.ts, plus the grouped targeted run covering gateway/browser/telegram touched tests until the stale browser relay case was removed.
  • Shared-state footgun removed: bundled plugins now use scoped openclaw/plugin-sdk/<channel> imports instead of the monolithic root, and the dead Chrome extension relay alias test is gone.
  • Still hurts: full pnpm test still hangs in the repo wrapper, and src/agents/pi-embedded-runner/run.overflow-compaction.loop.test.ts did not return a result before the wrapper had to be killed.

Why This Matters

  • The repo was red for reasons unrelated to the docs PRs that just landed.
  • That made every later change ambiguous because local validation could not be trusted.
  • This PR restores a believable local baseline for build/check and fixes a chunk of stale test drift.

Scope Boundary

  • Changed: stale test/config fixtures, startup auth typing, bundled plugin SDK import paths, one obsolete browser relay test, one unused import.
  • Not changed: runtime product behavior, gateway auth semantics, or the still-hanging full test wrapper behavior.

Verification

  • pnpm build
  • pnpm check
  • pnpm test -- src/wizard/setup.test.ts
  • pnpm test -- src/commands/agent/session.test.ts
  • pnpm test -- extensions/telegram/src/channel.test.ts
  • pnpm test -- extensions/telegram/src/thread-session-seeding.test.ts
  • pnpm test -- src/gateway/server-startup-preflight.test.ts src/wizard/setup.test.ts src/browser/chrome.launch-args.test.ts src/commands/agent/session.test.ts extensions/telegram/src/channel.test.ts extensions/telegram/src/conversation-route.base-session-key.test.ts extensions/telegram/src/thread-session-seeding.test.ts src/agents/pi-embedded-runner/run.overflow-compaction.loop.test.ts
    • result: browser relay test was obsolete and removed; wrapper still hangs on the overflow-compaction loop test path.

AI Assistance

  • AI-assisted
  • Testing degree: targeted

- what: repair stale type fixtures, remove an obsolete browser relay test, and migrate bundled plugins to scoped plugin-sdk subpaths
- why: build and check were red behind accumulated drift, which blocked trustworthy local validation after the docs cleanup landed
- risk: browser coverage now drops the removed extension-relay alias path, and full pnpm test still hangs in the repo wrapper outside the scoped test runs
@artemgetmann artemgetmann merged commit e88d41e into main Mar 25, 2026
3 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant