fix(gateway): block silent shared-service takeover#150
Merged
Conversation
- what: detect when the default shared gateway service already points at a different runtime/config and refuse silent overwrite unless takeover is explicitly allowed - why: consumer/tester worktrees kept hijacking the sacred main launch agent, which knocked the main Telegram bot offline - risk: legitimate shared-service recovery now requires the explicit --allow-shared-service-takeover escape hatch and profiled lanes must stay isolated by design
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Fast Path
openclaw gateway installcan no longer silently overwrite the sacred default shared gateway service when another runtime/worktree already owns it.pnpm test -- src/cli/daemon-cli/install.test.ts src/cli/daemon-cli/install.integration.test.ts src/cli/daemon-cli/register-service-commands.test.tsandpnpm buildboth passed in this worktree.--force --allow-shared-service-takeover; profiled tester/consumer/rescue lanes remain allowed.Why This Matters
ai.openclaw.gateway, which took the main Telegram bot down.Scope Boundary
--allow-shared-service-takeoverescape hatch for intentional recovery.AGENTS.mdanddocs/gateway/multiple-gateways.md.Verification
pnpm test -- src/cli/daemon-cli/install.test.ts src/cli/daemon-cli/install.integration.test.ts src/cli/daemon-cli/register-service-commands.test.tspnpm build--allow-shared-service-takeoverAI Assistance